Skip to content

Attempt to use reflinks by default on Linux #18117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zanieb merged 10 commits into from
Feb 23, 2026
Merged

Attempt to use reflinks by default on Linux #18117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8ce6644
Default to clone (reflink) link mode on Linux
claude Jan 30, 2026
4acf52a
Add cross-filesystem link tests with dedicated test env vars
zanieb Feb 19, 2026
529ce94
Review
zanieb Feb 19, 2026
b3c8774
Address review comments: simplify tests and update documentation
zanieb Feb 20, 2026
0139b39
Fix install_cross_device: don't recreate venv that test_context alrea…
zanieb Feb 20, 2026
d658adc
Fix install_cross_device snapshot: warning appears during install, no…
zanieb Feb 20, 2026
47bc5fe
Fix install_cross_device snapshot: correct continuation line indentat…
zanieb Feb 20, 2026
0373dbb
Address review: add FS name to test filters and inline canonical vari…
zanieb Feb 20, 2026
6ff7e66
Add cross-device tests for explicit copy and symlink link modes
zanieb Feb 20, 2026
7273d86
Use file-backed HFS+ disk image instead of RAM disk on macOS
zanieb Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,21 @@ jobs:
# the login password doesn't matter, but the keyring must be unlocked for the tests to work
run: gnome-keyring-daemon --components=secrets --daemonize --unlock <<< 'foobar'

- name: "Create btrfs filesystem"
run: |
sudo apt-get install -y btrfs-progs
truncate -s 1G /tmp/btrfs.img
mkfs.btrfs /tmp/btrfs.img
sudo mkdir /btrfs
sudo mount -o loop /tmp/btrfs.img /btrfs
sudo chown "$(id -u):$(id -g)" /btrfs

- name: "Create tmpfs filesystem"
run: |
sudo mkdir /tmpfs
sudo mount -t tmpfs -o size=256m tmpfs /tmpfs
sudo chown "$(id -u):$(id -g)" /tmpfs

- name: "Install cargo nextest"
uses: taiki-e/install-action@542cebaaed782771e619bd5609d97659d109c492 # v2.66.7
with:
Expand All @@ -70,6 +85,9 @@ jobs:
# Retry more than default to reduce flakes in CI
UV_HTTP_RETRIES: 5
RUST_BACKTRACE: 1
UV_INTERNAL__TEST_COW_FS: /btrfs
UV_INTERNAL__TEST_NOCOW_FS: /tmpfs
UV_INTERNAL__TEST_ALT_FS: /tmpfs
run: |
cargo nextest run \
--cargo-profile fast-build \
Expand Down Expand Up @@ -97,6 +115,12 @@ jobs:
- name: "Install Rust toolchain"
run: rustup show

- name: "Create HFS+ disk image (no reflink support)"
run: |
hdiutil create -size 256m -fs HFS+ -volname NoReflink /tmp/noreflink.dmg
hdiutil attach /tmp/noreflink.dmg
echo "HFS_MOUNT=/Volumes/NoReflink" >> "$GITHUB_ENV"

- uses: astral-sh/setup-uv@eac588ad8def6316056a12d4907a9d4d84ff7a3b # v7.3.0
with:
version: "0.10.2"
Expand All @@ -114,6 +138,11 @@ jobs:
# Retry more than default to reduce flakes in CI
UV_HTTP_RETRIES: 5
RUST_BACKTRACE: 1
# macOS tmpdir is on APFS which supports reflink
UV_INTERNAL__TEST_COW_FS: ${{ runner.temp }}
# HFS+ RAM disk does not support copy-on-write and is on a different device
UV_INTERNAL__TEST_NOCOW_FS: ${{ env.HFS_MOUNT }}
UV_INTERNAL__TEST_ALT_FS: ${{ env.HFS_MOUNT }}
run: |
cargo nextest run \
--cargo-profile fast-build \
Expand Down
10 changes: 5 additions & 5 deletions crates/uv-cli/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3236,7 +3236,7 @@ pub struct VenvArgs {
///
/// This option is only used for installing seed packages.
///
/// Defaults to `clone` (also known as Copy-on-Write) on macOS, and `hardlink` on Linux and
/// Defaults to `clone` (also known as Copy-on-Write) on macOS and Linux, and `hardlink` on
/// Windows.
///
/// WARNING: The use of symlink link mode is discouraged, as they create tight coupling between
Expand Down Expand Up @@ -5908,7 +5908,7 @@ pub struct ToolUpgradeArgs {

/// The method to use when installing packages from the global cache.
///
/// Defaults to `clone` (also known as Copy-on-Write) on macOS, and `hardlink` on Linux and
/// Defaults to `clone` (also known as Copy-on-Write) on macOS and Linux, and `hardlink` on
/// Windows.
///
/// WARNING: The use of symlink link mode is discouraged, as they create tight coupling between
Expand Down Expand Up @@ -6963,7 +6963,7 @@ pub struct InstallerArgs {

/// The method to use when installing packages from the global cache.
///
/// Defaults to `clone` (also known as Copy-on-Write) on macOS, and `hardlink` on Linux and
/// Defaults to `clone` (also known as Copy-on-Write) on macOS and Linux, and `hardlink` on
/// Windows.
///
/// WARNING: The use of symlink link mode is discouraged, as they create tight coupling between
Expand Down Expand Up @@ -7203,7 +7203,7 @@ pub struct ResolverArgs {
///
/// This option is only used when building source distributions.
///
/// Defaults to `clone` (also known as Copy-on-Write) on macOS, and `hardlink` on Linux and
/// Defaults to `clone` (also known as Copy-on-Write) on macOS and Linux, and `hardlink` on
/// Windows.
///
/// WARNING: The use of symlink link mode is discouraged, as they create tight coupling between
Expand Down Expand Up @@ -7442,7 +7442,7 @@ pub struct ResolverInstallerArgs {

/// The method to use when installing packages from the global cache.
///
/// Defaults to `clone` (also known as Copy-on-Write) on macOS, and `hardlink` on Linux and
/// Defaults to `clone` (also known as Copy-on-Write) on macOS and Linux, and `hardlink` on
/// Windows.
///
/// WARNING: The use of symlink link mode is discouraged, as they create tight coupling between
Expand Down
Loading
Loading