Update stale comments and downgrade a warn!#18101
Merged
Conversation
This came out of an experience on whether claude code can find missing updates in from changes in PRs. #### #18096 — Propagate project-level conflicts to package extras (zanieb) **Stale docstring on `filter_by_group`**: In `crates/uv-resolver/src/resolver/environment.rs`, the docstring still says "Include rules have no effect in `included_by_group`". After this PR, include rules DO affect `included_by_group` when a project-level exclusion exists for a package — an explicit inclusion for a specific extra overrides the exclusion. #### #18081 — Filter `pylock.toml` wheels by tags and `requires-python` (konstin) **Inverted docstring on `is_wheel_unreachable`**: At `crates/uv-resolver/src/lock/mod.rs:6088`, the docstring says "Returns `false` if the wheel is definitely unreachable" but the function actually returns `true` when unreachable. The `true`/`false` are swapped. #### #18075 — make missing files warning debug (dead10ck) **analogous `warn!` not changed in flat_index.rs**: `crates/uv-client/src/flat_index.rs:215` has a similar `warn!("Skipping file in {}: {err}", &url)` that exhibits the same noisy pattern. Arguable whether flat indexes warrant the same change since they're user-configured and less likely to trigger mass warnings.
zanieb
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came out of an experience on whether claude code can find missing updates in from changes in PRs:
#18096 — Propagate project-level conflicts to package extras (zanieb)
Stale docstring on
filter_by_group: Incrates/uv-resolver/src/resolver/environment.rs, the docstring still says "Include rules have no effect inincluded_by_group". After this PR, include rules DO affectincluded_by_groupwhen a project-level exclusion exists for a package — an explicit inclusion for a specific extra overrides the exclusion.#18081 — Filter
pylock.tomlwheels by tags andrequires-python(konstin)Inverted docstring on
is_wheel_unreachable: Atcrates/uv-resolver/src/lock/mod.rs:6088, the docstring says "Returnsfalseif the wheel is definitely unreachable" but the function actually returnstruewhen unreachable. Thetrue/falseare swapped.#18075 — make missing files warning debug (dead10ck)
Analogous
warn!not changed in flat_index.rs:crates/uv-client/src/flat_index.rs:215has a similarwarn!("Skipping file in {}: {err}", &url)that exhibits the same noisy pattern. Arguable whether flat indexes warrant the same change since they're user-configured and less likely to trigger mass warnings.