Respect [tool.uv.sources] for extra build dependencies in uv build and uv run --with#18085
Draft
zanieb wants to merge 1 commit intoastral-sh:mainfrom
Draft
Respect [tool.uv.sources] for extra build dependencies in uv build and uv run --with#18085zanieb wants to merge 1 commit intoastral-sh:mainfrom
[tool.uv.sources] for extra build dependencies in uv build and uv run --with#18085zanieb wants to merge 1 commit intoastral-sh:mainfrom
Conversation
When `[tool.uv.sources]` pins a package to an explicit index, that index pinning was not being applied to extra build dependencies. This was because the lowering used `from_non_lowered()` which ignores sources/index metadata. Fix by adding an optional `workspace` parameter to `resolve_environment`, `sync_environment`, and `resolve_names`. When a workspace is provided, these functions use `from_workspace()` to lower extra build dependencies with full source resolution, including index pinning from `[tool.uv.sources]`. For `uv build`, the lowering is done in `build_impl()` using a settings workspace discovered from the project directory. Closes astral-sh#18059 https://claude.ai/code/session_01MEK9fN6ryBcGgqWdnqcgoc
zanieb
changed the title
[tool.uv.sources] for extra build dependencies[tool.uv.sources] for extra build dependencies in uv build and uv run --with
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered via #18059 but does not close it as the problem there is that they're not respected consistently in
uv pip