Conversation
zanieb
force-pushed
the
zb/uv-fs-copy
branch
2 times, most recently
from
b95e019 to
8527ca6
Compare
charliermarsh
approved these changes
Feb 4, 2026
zanieb
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
zanieb
force-pushed
the
zb/uv-fs-copy
branch
3 times, most recently
from
5b3c808 to
e2f396b
Compare
zanieb
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
zanieb
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
konstin
reviewed
Feb 12, 2026
| /// For wheels, this checks if compressed tag sets (`.`-separated) are sorted. | ||
| /// | ||
| /// See: <https://github.com/pypi/warehouse/issues/18129> | ||
| pub fn has_sorted_tags(&self) -> bool { |
Member
There was a problem hiding this comment.
I think this PR needs a rebase, those changes don't fit in here.
Member
Author
There was a problem hiding this comment.
Weird not sure how I got that branch into my last commit. Fixing...
zanieb
force-pushed
the
zb/uv-fs-copy
branch
from
3d82db6 to
60c174e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates our file copying and linking logic in
uv-fsinstead of having a duplicate implementation inuv-install-wheel. This required introducing some new abstractions inuv-fsto support the features wheel installation needs.I think this is a blocker to improving our reflink handling in #17753 and also generally desirable since the copy fallback logic is complicated.