Don't preserve timestamp in streaming unzip #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't preserve mtime to work around alexcrichton/tar-rs#349. Same as #634 except for the streaming unzip. Fixes #1748.
konstin
commented
Feb 20, 2024
crates/uv-extract/src/stream.rs
Outdated
| @@ -93,6 +93,7 @@ pub async fn untar<R: tokio::io::AsyncBufRead + Unpin>( | |||
| let decompressed_bytes = async_compression::tokio::bufread::GzipDecoder::new(reader); | |||
| let mut archive = tokio_tar::ArchiveBuilder::new(decompressed_bytes) | |||
| .set_preserve_permissions(false) | |||
There was a problem hiding this comment.
@charliermarsh Do you remember why we have that here but not in the sync impl? Docs say "This flag is disabled by default" in both impls.
There was a problem hiding this comment.
I think this is a mistake / typo. I probably meant for this to be mtime.
There was a problem hiding this comment.
We probably should be preserving permissions, right?
There was a problem hiding this comment.
Yeah I was wondering if we were missing that for tars.
charliermarsh
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Don't preserve mtime to work around alexcrichton/tar-rs#349. Same as #634 except for the streaming unzip.
Fixes #1748.
Test Plan
Added the tomli source dist as test case.