Avoid flagging proxied Git URLs as ambiguous authority#17234
Merged
charliermarsh merged 1 commit intomainfrom Dec 25, 2025
Merged
Avoid flagging proxied Git URLs as ambiguous authority#17234charliermarsh merged 1 commit intomainfrom
charliermarsh merged 1 commit intomainfrom
Conversation
woodruffw
approved these changes
Dec 25, 2025
Member
woodruffw
left a comment
There was a problem hiding this comment.
LGTM!
I was surprised by this, but these kinds of nested URLs are valid according to both RFC 3986 and WHATWG (the nuance for WHATWG being that git+https isn't a recognized browser scheme, but that doesn't matter in our context).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #17214.