Skip to content

Avoid flagging proxied Git URLs as ambiguous authority#17234

Merged
charliermarsh merged 1 commit intomainfrom
charlie/ambiguous-authority
Dec 25, 2025
Merged

Avoid flagging proxied Git URLs as ambiguous authority#17234
charliermarsh merged 1 commit intomainfrom
charlie/ambiguous-authority

Conversation

@charliermarsh
Copy link
Member

Summary

Closes #17214.

Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I was surprised by this, but these kinds of nested URLs are valid according to both RFC 3986 and WHATWG (the nuance for WHATWG being that git+https isn't a recognized browser scheme, but that doesn't matter in our context).

@charliermarsh charliermarsh marked this pull request as ready for review December 25, 2025 11:42
@charliermarsh charliermarsh merged commit 4269f88 into main Dec 25, 2025
102 checks passed
@charliermarsh charliermarsh deleted the charlie/ambiguous-authority branch December 25, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

panic: AmbiguousAuthority when using proxy url with git source + branch

2 participants