Skip to content

Use nextest profiles to configure CI#17220

Merged
EliteTK merged 2 commits intomainfrom
tk/ci-profiles
Dec 29, 2025
Merged

Use nextest profiles to configure CI#17220
EliteTK merged 2 commits intomainfrom
tk/ci-profiles

Conversation

@EliteTK
Copy link
Copy Markdown
Contributor

@EliteTK EliteTK commented Dec 22, 2025

This centralises the configuration and allows certain overrides to be CI specific.

@EliteTK EliteTK added internal A refactor or improvement that is not user-facing test:skip Disable running tests for a pull request and removed test:skip Disable running tests for a pull request labels Dec 22, 2025
@EliteTK EliteTK temporarily deployed to uv-test-registries December 22, 2025 20:33 — with GitHub Actions Inactive
@EliteTK EliteTK added the test:macos Enable macOS tests for a pull request label Dec 22, 2025
@EliteTK EliteTK temporarily deployed to uv-test-registries December 22, 2025 20:44 — with GitHub Actions Inactive
@EliteTK EliteTK temporarily deployed to uv-test-registries December 22, 2025 21:00 — with GitHub Actions Inactive
@EliteTK
Copy link
Copy Markdown
Contributor Author

EliteTK commented Dec 22, 2025

This is really for #17177. I wasn't sure if it was okay to just bump the nextest version to 0.9.115 so for now I have just added a commit which manually expands all the profiles.

@EliteTK EliteTK marked this pull request as ready for review December 22, 2025 21:03
@EliteTK EliteTK requested a review from zanieb December 22, 2025 21:03
zanieb
zanieb approved these changes Dec 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do they support layering profiles? i.e., can we inherit most of these ci settings from a single profile?

@EliteTK
Copy link
Copy Markdown
Contributor Author

EliteTK commented Dec 22, 2025

Yes they do support layering but the version of nextest we're using doesn't support it. I wasn't sure if it was okay to bump it so I added the commit manually un-layering these.

@zanieb
Copy link
Copy Markdown
Member

zanieb commented Dec 22, 2025

It's fine to bump the version imo as long as you audited it for anything malicious.

@EliteTK
Copy link
Copy Markdown
Contributor Author

EliteTK commented Dec 22, 2025

Looks like I'd need to update the taiki-e/install-action to do that. I'll maybe just create an issue and get on it next week and merge this as is (if the git-lfs tests ever succeed)...

@EliteTK EliteTK mentioned this pull request Dec 29, 2025
Closed
@EliteTK EliteTK merged commit c19e22f into main Dec 29, 2025
278 of 282 checks passed
@EliteTK EliteTK deleted the tk/ci-profiles branch December 29, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanieb zanieb zanieb approved these changes

Assignees

No one assigned

Labels

internal A refactor or improvement that is not user-facing test:macos Enable macOS tests for a pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EliteTK @zanieb