Make uv pip compile always attempt to honour the --python argument#17219
Closed
EliteTK wants to merge 1 commit intotk/pip-compile-missing-py-2from
Closed
Make uv pip compile always attempt to honour the --python argument#17219EliteTK wants to merge 1 commit intotk/pip-compile-missing-py-2from
uv pip compile always attempt to honour the --python argument#17219EliteTK wants to merge 1 commit intotk/pip-compile-missing-py-2from
Conversation
This means that an explicit `uv pip compile --python <ver>` will always attempt to honour the version.
EliteTK
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #16709.
Previous when
uv pip compile --python <ver>was used and<ver>was a "simple Python version request" (i.e.PythonVersion::from_strsucceeded) thenuv pip compilewould act as if the version was passed using--python-versioninstead (with no--python) which in turn meant that it turned into a loose requirement which could be satisfied withfind_best.This PR makes
uv pip compile --python <simple-ver>act likeuv pip compile --python <simple-ver> --python-version <simple-ver>which I believe is more accurate.Test Plan
Existing tests were adjusted since they already covered this case.