Remove temporary with_added_extension in favour of stablised standard method#16588
Closed
crh23 wants to merge 1 commit intoastral-sh:mainfrom
Closed
Remove temporary with_added_extension in favour of stablised standard method#16588crh23 wants to merge 1 commit intoastral-sh:mainfrom
crh23 wants to merge 1 commit intoastral-sh:mainfrom
Conversation
Contributor
Author
|
Ah scratch that - I'll close this until project rust version reaches 1.91.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the with_added_extension function created in #15300 (and moved in #15610) with the now-stabilised version PathBuf::with_added_extension.
Test Plan
Uses existing tests (which were added in the original PR specifically to enable this change)