Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove uv itself on pip sync #1649

Merged

Conversation

flyaroundme
Copy link
Contributor

@flyaroundme flyaroundme commented Feb 18, 2024

Summary

Added uv to the list of the preserved packages when building the installer plan. In that case uv is not going to be removed when, for example, using python -m uv pip sync requirements.txt when requirements.txt does not contain uv, but uv is installed in that venv.

Closes #1631

Test Plan

Got through the example attached to #1631 and did not see the uv deletion in the output

$ python -m uv pip sync requirements.txt
Installed 1 package in 20ms
 + ruff==0.2.2

@charliermarsh charliermarsh added the bug Something isn't working label Feb 18, 2024
@charliermarsh
Copy link
Member

Nice, thank you!

@charliermarsh charliermarsh enabled auto-merge (squash) February 18, 2024 14:38
@charliermarsh
Copy link
Member

Welcome to the project.

@charliermarsh charliermarsh merged commit c04f597 into astral-sh:main Feb 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uv pip sync uninstalls uv itself when installed into the virtual env
2 participants