-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove setuptools & wheel from seed packages (#1602) #1613
Merged
zanieb
merged 6 commits into
astral-sh:main
from
arjunnn:arjun/remove-setuptools-wheel-from-seed
Feb 18, 2024
Merged
Remove setuptools & wheel from seed packages (#1602) #1613
zanieb
merged 6 commits into
astral-sh:main
from
arjunnn:arjun/remove-setuptools-wheel-from-seed
Feb 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! Thanks for opening a pull request. We'll only want to do this when the Python version is 3.12 or newer. |
zanieb
reviewed
Feb 17, 2024
zanieb
requested changes
Feb 17, 2024
if python version is <3.12
zanieb
reviewed
Feb 18, 2024
zanieb
reviewed
Feb 18, 2024
Thank you! |
zanieb
approved these changes
Feb 18, 2024
This was referenced Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compatibility
Compatibility with a specification or another tool
virtualenv
Related to virtual environments
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed
wheel
andsetuptools
from seed packages list when creating a virtual environmentCloses #1602
Test Plan
Ran the command
![image](https://private-user-images.githubusercontent.com/6116387/305667069-14ed2da6-1b3e-4598-a49f-29dd8c4cb19b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU1OTQ2MjgsIm5iZiI6MTcyNTU5NDMyOCwicGF0aCI6Ii82MTE2Mzg3LzMwNTY2NzA2OS0xNGVkMmRhNi0xYjNlLTQ1OTgtYTQ5Zi0yOWRkOGM0Y2IxOWIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkwNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MDZUMDM0NTI4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MzdjMWZiNWExOTNlYWRhNWJmMzc3Y2U0Nzg2YjA1MzZiY2NhYmNhMmIzMjJkM2QxYjE4YjlmZTNiZjI1ZWYwMCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.kTBVIpCoWzGtN6IZNgqfLTCdIrQ93k_HJnVcGCpgx4g)
cargo nextest run
: