Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setuptools & wheel from seed packages (#1602) #1613

Merged

Conversation

arjunnn
Copy link
Contributor

@arjunnn arjunnn commented Feb 17, 2024

Summary

Removed wheel and setuptools from seed packages list when creating a virtual environment

Closes #1602

Test Plan

Ran the command cargo nextest run :
image

@zanieb zanieb added the compatibility Compatibility with a specification or another tool label Feb 17, 2024
@zanieb
Copy link
Member

zanieb commented Feb 17, 2024

Hi! Thanks for opening a pull request.

We'll only want to do this when the Python version is 3.12 or newer.

if python version is <3.12
@zanieb zanieb self-assigned this Feb 17, 2024
crates/uv/tests/venv.rs Outdated Show resolved Hide resolved
@arjunnn arjunnn requested a review from zanieb February 18, 2024 12:37
@zanieb
Copy link
Member

zanieb commented Feb 18, 2024

Thank you!

@zanieb zanieb enabled auto-merge (squash) February 18, 2024 21:17
@zanieb zanieb added the virtualenv Related to virtual environments label Feb 18, 2024
@zanieb zanieb merged commit 3ed386c into astral-sh:main Feb 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Compatibility with a specification or another tool virtualenv Related to virtual environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seeding venv adds setuptools and wheel on Python 3.12
2 participants