Avoid propagating top-level options to sub-resolutions #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/rec
branch
4 times, most recently
from
1c0beee
to
18156f8
Compare
charliermarsh
force-pushed
the
charlie/rec
branch
from
18156f8
to
03ead0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It's incorrect to pass the resolution and dependency mode down to the
BuildDispatch, since it means that we'll use--no-depswhen building source distributions. If you set resolution tolowest, it also means we end up using (e.g.) the lowest version ofwheel, which also doesn't make sense.It's fine to pass
--exclude-newer.Closes #1355.
Closes #1563.