-
Notifications
You must be signed in to change notification settings - Fork 3k
Ignore inferred conflict marker when determining if lockfile is up-to-date #15884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10986,6 +10986,24 @@ fn transitive_group_conflicts_shallow() -> Result<()> { | |
| "#, | ||
| )?; | ||
|
|
||
| uv_snapshot!(context.filters(), context.lock(), @r" | ||
| success: true | ||
| exit_code: 0 | ||
| ----- stdout ----- | ||
|
|
||
| ----- stderr ----- | ||
| Resolved 5 packages in [TIME] | ||
| "); | ||
|
|
||
| uv_snapshot!(context.filters(), context.lock().arg("--check"), @r" | ||
| success: true | ||
| exit_code: 0 | ||
| ----- stdout ----- | ||
|
|
||
| ----- stderr ----- | ||
| Resolved 5 packages in [TIME] | ||
| "); | ||
|
|
||
| uv_snapshot!(context.filters(), context.sync(), @r" | ||
| success: true | ||
| exit_code: 0 | ||
|
|
@@ -11037,7 +11055,7 @@ fn transitive_group_conflicts_shallow() -> Result<()> { | |
|
|
||
| ----- stderr ----- | ||
| Resolved 5 packages in [TIME] | ||
| error: Groups `dev` and `magic` are incompatible with the transitively inferred conflicts: {`example:dev`, `example:magic`} | ||
| error: Groups `dev` and `magic` are incompatible with the declared conflicts: {`example:dev`, `example:magic`} | ||
|
Comment on lines
11057
to
+11058
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unfortunately this regresses the error message, I'll need to investigate that further.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Presumably the problem is that we're installing from the lockfile instead of a fresh resolution, which drops this information. I think there are a few options here
I sort of argue for (4), while we might want (2) or (3) in the future, they seem like a fair bit of work and the improvement in the error message is quite minor. |
||
| "); | ||
|
|
||
| Ok(()) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can see the failure from the issue in 44522f0