Add graceful fallback for Artifactory indexes #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/slice
branch
from
f367d52
to
62e4379
Compare
charliermarsh
commented
Feb 17, 2024
Cargo.toml
Outdated
| @@ -21,7 +21,7 @@ anstream = { version = "0.6.5" } | |||
| anyhow = { version = "1.0.79" } | |||
| async-compression = { version = "0.4.6" } | |||
| async-trait = { version = "0.1.77" } | |||
| async_http_range_reader = { version = "0.5.0" } | |||
| async_http_range_reader = { git = "https://github.com/charliermarsh/async_http_range_reader", rev = "725e69903e637c9ff66360fa74a1b494d7c47d29" } | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Merged and released with many thanks to @baszalmstra!
zanieb
reviewed
Feb 17, 2024
zanieb
approved these changes
Feb 17, 2024
charliermarsh
force-pushed
the
charlie/slice
branch
2 times, most recently
from
ba6a9fc
to
c6bff41
Compare
charliermarsh
force-pushed
the
charlie/slice
branch
from
c6bff41
to
8f159ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are more details in #1370, but it looks like Artifactory servers have incorrect behavior when it comes to HTTP range requests, in that they return
Accept-Ranges: bytes, but then incorrectly return 200 requests when you actually ask for a given range.This PR ensures that we fallback gracefully in this case. It's built on prefix-dev/async_http_range_reader#5. Assuming that gets merged upstream, we can then remove the Git dependency.
Closes #1370.
Test Plan
cargo run pip install requests -i https://killjoyuvbug.jfrog.io/artifactory/api/pypi/pypi/simple --verbose