Add error trace to invalid package format#15626
Merged
Conversation
In #11636, we're getting reports for installation flakes that report an invalid package format for what appears to be a network problem. Since we're cutting the error reporting to the first error message in the chain, we're not reporting the actual network error underneath it. This PR displays the whole error chain for invalid package format errors, so we can debug and eventually catch-and-retry #11636.
konstin
commented
Sep 2, 2025
|
|
||
| /// Display the error chain for unavailable packages. | ||
| #[derive(Debug, Clone)] | ||
| pub struct UnavailableErrorChain(Arc<dyn std::error::Error + Send + Sync + 'static>); |
Member
Author
There was a problem hiding this comment.
Name and location of the type is up for bikeshedding. Maybe we want a generic version in uv-warnings?
konstin
commented
Sep 2, 2025
Comment on lines
+2625
to
+2627
| hint: The structure of `foo` was invalid | ||
| Caused by: Failed to read from zip file | ||
| Caused by: unable to locate the end of central directory record |
Member
Author
There was a problem hiding this comment.
There's a chance here that user's mistake this hint for an error message (since we're using the familiar error format), not sure if we can make it clearer that the resolution error trace above is the actual error.
konstin
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
zanieb
approved these changes
Sep 2, 2025
konstin
deleted the
konsti/show-error-trace-for-broken-package-layout
branch
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Sep 5, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.8.14` -> `0.8.15` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.8.15`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0815) [Compare Source](astral-sh/uv@0.8.14...0.8.15) ##### Python - Upgrade SQLite 3.50.4 in CPython builds for [CVE-2025-6965](GHSA-2m69-gcr7-jv3q) (see also [python/cpython#137134](python/cpython#137134)) ##### Enhancements - Add `uv auth` commands for credential management ([#​15570](astral-sh/uv#15570)) - Add pyx support to `uv auth` commands ([#​15636](astral-sh/uv#15636)) - Add `uv tree --show-sizes` to show package sizes ([#​15531](astral-sh/uv#15531)) - Add `--python-platform riscv64-unknown-linux` ([#​15630](astral-sh/uv#15630)) - Add `--python-platform` to `uv run` and `uv tool` ([#​15515](astral-sh/uv#15515)) - Add `uv publish --dry-run` ([#​15638](astral-sh/uv#15638)) - Add zstandard support for wheels ([#​15645](astral-sh/uv#15645)) - Allow registries to pre-provide core metadata ([#​15644](astral-sh/uv#15644)) - Retry streaming Python and binary download errors ([#​15567](astral-sh/uv#15567)) ##### Bug fixes - Fix settings rendering for `extra-build-dependencies` ([#​15622](astral-sh/uv#15622)) - Skip non-existent directories in bytecode compilation ([#​15608](astral-sh/uv#15608)) ##### Error messages - Add error trace to invalid package format ([#​15626](astral-sh/uv#15626)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS45My4zIiwidXBkYXRlZEluVmVyIjoiNDEuOTMuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #11636, we're getting reports for installation flakes that report an invalid package format for what appears to be a network problem. Since we're cutting the error reporting to the first error message in the chain, we're not reporting the actual network error underneath it.
This PR displays the whole error chain for invalid package format errors, so we can debug and eventually catch-and-retry #11636.