Skip to content

Use a dedicated wire type for credentials serialization#15599

Merged
charliermarsh merged 1 commit intofeature/authfrom
charlie/auth-wire
Aug 31, 2025
Merged

Use a dedicated wire type for credentials serialization#15599
charliermarsh merged 1 commit intofeature/authfrom
charlie/auth-wire

Conversation

@charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Aug 30, 2025

Summary

This is a little closer to what we do elsewhere when we want to encapsulate differences in the serialization format.

@charliermarsh charliermarsh requested a review from zanieb August 30, 2025 18:42
@charliermarsh charliermarsh added the internal A refactor or improvement that is not user-facing label Aug 30, 2025
@charliermarsh charliermarsh marked this pull request as ready for review August 30, 2025 18:42
@charliermarsh charliermarsh force-pushed the feature/auth branch 2 times, most recently from ad0ff24 to ab9ee1a Compare August 30, 2025 20:05
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh merged commit 992619c into feature/auth Aug 31, 2025
96 checks passed
@charliermarsh charliermarsh deleted the charlie/auth-wire branch August 31, 2025 01:18
zanieb pushed a commit that referenced this pull request Aug 31, 2025
This is a little closer to what we do elsewhere when we want to
encapsulate differences in the serialization format.
zanieb pushed a commit that referenced this pull request Sep 2, 2025
This is a little closer to what we do elsewhere when we want to
encapsulate differences in the serialization format.
@zanieb zanieb mentioned this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal A refactor or improvement that is not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants