Skip to content

Update messaging for uv auth #15573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zanieb merged 1 commit into from
Aug 28, 2025
Merged

Update messaging for uv auth #15573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions crates/uv/src/commands/auth/login.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
use anyhow::{Result, bail};
use std::fmt::Write;

use anyhow::{Result, bail};
use console::Term;
use owo_colors::OwoColorize;

use uv_auth::Credentials;
use uv_configuration::{KeyringProviderType, Service};
use uv_preview::Preview;
Expand Down Expand Up @@ -116,6 +118,10 @@ pub(crate) async fn login(
let credentials = Credentials::basic(Some(username), Some(password));
provider.store(url, &credentials).await?;

writeln!(printer.stderr(), "Logged in to {display_url}")?;
writeln!(
printer.stderr(),
"Stored credentials for {}",
display_url.cyan()
)?;
Ok(ExitStatus::Success)
}
11 changes: 9 additions & 2 deletions crates/uv/src/commands/auth/logout.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
use anyhow::{Context, Result, bail};
use std::fmt::Write;

use anyhow::{Context, Result, bail};
use owo_colors::OwoColorize;

use uv_auth::Credentials;
use uv_configuration::{KeyringProviderType, Service};
use uv_preview::Preview;
Expand Down Expand Up @@ -59,7 +62,11 @@ pub(crate) async fn logout(
.await
.with_context(|| format!("Unable to remove credentials for {display_url}"))?;

writeln!(printer.stderr(), "Logged out of {display_url}")?;
writeln!(
printer.stderr(),
"Removed credentials for {}",
display_url.cyan()
)?;

Ok(ExitStatus::Success)
}
34 changes: 17 additions & 17 deletions crates/uv/tests/it/auth.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ fn add_package_native_keyring() -> Result<()> {

----- stderr -----
warning: The native keyring provider is experimental and may change without warning. Pass `--preview-features native-keyring` to disable this warning.
Logged in to public@https://pypi-proxy.fly.dev/basic-auth/simple
Stored credentials for public@https://pypi-proxy.fly.dev/basic-auth/simple
"
);

Expand Down Expand Up @@ -93,7 +93,7 @@ fn add_package_native_keyring() -> Result<()> {

----- stderr -----
warning: The native keyring provider is experimental and may change without warning. Pass `--preview-features native-keyring` to disable this warning.
Logged out of public@https://pypi-proxy.fly.dev/basic-auth/simple
Removed credentials for public@https://pypi-proxy.fly.dev/basic-auth/simple
"
);

Expand Down Expand Up @@ -199,7 +199,7 @@ fn token_native_keyring() -> Result<()> {

----- stderr -----
warning: The native keyring provider is experimental and may change without warning. Pass `--preview-features native-keyring` to disable this warning.
Logged in to public@https://pypi-proxy.fly.dev/basic-auth/simple
Stored credentials for public@https://pypi-proxy.fly.dev/basic-auth/simple
"
);

Expand Down Expand Up @@ -264,7 +264,7 @@ fn token_native_keyring() -> Result<()> {

----- stderr -----
warning: The native keyring provider is experimental and may change without warning. Pass `--preview-features native-keyring` to disable this warning.
Logged in to https://pypi-proxy.fly.dev/basic-auth/simple
Stored credentials for https://pypi-proxy.fly.dev/basic-auth/simple
"
);

Expand Down Expand Up @@ -493,7 +493,7 @@ fn login_native_keyring() -> Result<()> {

----- stderr -----
warning: The native keyring provider is experimental and may change without warning. Pass `--preview-features native-keyring` to disable this warning.
Logged in to public@https://pypi-proxy.fly.dev/basic-auth/simple
Stored credentials for public@https://pypi-proxy.fly.dev/basic-auth/simple
"
);

Expand Down Expand Up @@ -525,7 +525,7 @@ fn login_token_native_keyring() -> Result<()> {

----- stderr -----
warning: The native keyring provider is experimental and may change without warning. Pass `--preview-features native-keyring` to disable this warning.
Logged in to https://pypi-proxy.fly.dev/basic-auth/simple
Stored credentials for https://pypi-proxy.fly.dev/basic-auth/simple
"
);

Expand Down Expand Up @@ -568,7 +568,7 @@ fn logout_native_keyring() -> Result<()> {

----- stderr -----
warning: The native keyring provider is experimental and may change without warning. Pass `--preview-features native-keyring` to disable this warning.
Logged out of https://pypi-proxy.fly.dev/basic-auth/simple
Removed credentials for https://pypi-proxy.fly.dev/basic-auth/simple
");

// Logout before logging in (without a username)
Expand Down Expand Up @@ -618,7 +618,7 @@ fn logout_native_keyring() -> Result<()> {

----- stderr -----
warning: The native keyring provider is experimental and may change without warning. Pass `--preview-features native-keyring` to disable this warning.
Logged in to public@https://pypi-proxy.fly.dev/basic-auth/simple
Stored credentials for public@https://pypi-proxy.fly.dev/basic-auth/simple
"
);

Expand Down Expand Up @@ -651,7 +651,7 @@ fn logout_native_keyring() -> Result<()> {

----- stderr -----
warning: The native keyring provider is experimental and may change without warning. Pass `--preview-features native-keyring` to disable this warning.
Logged out of public@https://pypi-proxy.fly.dev/basic-auth/simple
Removed credentials for public@https://pypi-proxy.fly.dev/basic-auth/simple
");

// Login again
Expand All @@ -678,7 +678,7 @@ fn logout_native_keyring() -> Result<()> {

----- stderr -----
warning: The native keyring provider is experimental and may change without warning. Pass `--preview-features native-keyring` to disable this warning.
Logged out of public@https://pypi-proxy.fly.dev/basic-auth/simple
Removed credentials for public@https://pypi-proxy.fly.dev/basic-auth/simple
");

// Conflict between --username and a URL username is rejected
Expand Down Expand Up @@ -738,7 +738,7 @@ fn logout_token_native_keyring() -> Result<()> {

----- stderr -----
warning: The native keyring provider is experimental and may change without warning. Pass `--preview-features native-keyring` to disable this warning.
Logged in to https://pypi-proxy.fly.dev/basic-auth/simple
Stored credentials for https://pypi-proxy.fly.dev/basic-auth/simple
"
);

Expand All @@ -753,7 +753,7 @@ fn logout_token_native_keyring() -> Result<()> {

----- stderr -----
warning: The native keyring provider is experimental and may change without warning. Pass `--preview-features native-keyring` to disable this warning.
Logged out of https://pypi-proxy.fly.dev/basic-auth/simple
Removed credentials for https://pypi-proxy.fly.dev/basic-auth/simple
");

Ok(())
Expand All @@ -778,7 +778,7 @@ fn login_native_keyring_url() {

----- stderr -----
warning: The native keyring provider is experimental and may change without warning. Pass `--preview-features native-keyring` to disable this warning.
Logged in to test@https://example.com/
Stored credentials for test@https://example.com/
");

// HTTP URLs are not allowed - only HTTPS
Expand Down Expand Up @@ -814,7 +814,7 @@ fn login_native_keyring_url() {

----- stderr -----
warning: The native keyring provider is experimental and may change without warning. Pass `--preview-features native-keyring` to disable this warning.
Logged in to test@https://example.com/
Stored credentials for test@https://example.com/
");

// A domain-only service with a path also gets https:// prepended
Expand All @@ -832,7 +832,7 @@ fn login_native_keyring_url() {

----- stderr -----
warning: The native keyring provider is experimental and may change without warning. Pass `--preview-features native-keyring` to disable this warning.
Logged in to test@https://example.com/simple
Stored credentials for test@https://example.com/simple
");

// An invalid URL is rejected
Expand Down Expand Up @@ -865,7 +865,7 @@ fn login_native_keyring_url() {

----- stderr -----
warning: The native keyring provider is experimental and may change without warning. Pass `--preview-features native-keyring` to disable this warning.
Logged in to test@https://example.com/simple
Stored credentials for test@https://example.com/simple
");

// URL with embedded username and separate password works
Expand All @@ -881,7 +881,7 @@ fn login_native_keyring_url() {

----- stderr -----
warning: The native keyring provider is experimental and may change without warning. Pass `--preview-features native-keyring` to disable this warning.
Logged in to test@https://example.com/simple
Stored credentials for test@https://example.com/simple
");

// Conflict between --username and URL username is rejected
Expand Down
Loading