Stop leaking strings in Python downloads#15418
Merged
Conversation
We should not unnecessarily leak memory.
konstin
commented
Aug 21, 2025
Comment on lines
+330
to
+331
| url: Some(download.url().clone()), | ||
| sha256: download.sha256().cloned(), |
Member
Author
There was a problem hiding this comment.
This only allocates if we have a Cow::Owned
konstin
commented
Aug 21, 2025
|
|
||
| pub fn url(&self) -> &'static str { | ||
| self.url | ||
| pub fn url(&self) -> &Cow<'static, str> { |
Member
Author
There was a problem hiding this comment.
Returning the full Cow here allows the cheap clones below.
konstin
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
Member
zanieb
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should not unnecessarily leak memory. Instead, we follow the general patterns and use
Cowfor strings that can be from either a static or a dynamic source.