Include all site packages directories in ephemeral environment overlays#15121
Merged
Include all site packages directories in ephemeral environment overlays#15121
Conversation
zanieb
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
zanieb
force-pushed
the
zb/fix-site-package
branch
from
7349da2 to
80fab6b
Compare
zanieb
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
zanieb
force-pushed
the
zb/fix-site-package
branch
from
80fab6b to
95687c7
Compare
zanieb
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
zanieb
force-pushed
the
zb/fix-site-package
branch
from
95687c7 to
01e2251
Compare
zanieb
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
zanieb
force-pushed
the
zb/fix-site-package
branch
from
01e2251 to
18ec9bd
Compare
zanieb
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
zanieb
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
Member
Author
|
This is failing because we only use purelib and platlib to determine site packages but we need to actually read all of the site directories. |
zanieb
force-pushed
the
zb/fix-site-package
branch
from
7d054b2 to
a7114cf
Compare
zanieb
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
zanieb
force-pushed
the
zb/fix-site-package
branch
from
a7114cf to
91d30a2
Compare
zanieb
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
zanieb
force-pushed
the
zb/fix-site-package
branch
from
91d30a2 to
6329197
Compare
zanieb
commented
Aug 8, 2025
| - name: "Test `uv run` with system Python" | ||
| run: | | ||
| ./uv run -p python3.11 -v python -c "import debian" | ||
| ./uv run -p python3.11 -v --with anyio python -c "import debian" |
Member
Author
There was a problem hiding this comment.
This would fail without this change
zanieb
force-pushed
the
zb/fix-site-package
branch
from
6329197 to
4706269
Compare
zanieb
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
Member
Author
|
Interesting, now I broke something else. Will investigate that. |
zanieb
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
geofft
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #15113
The case in the linked issue is that we perhaps should not be allowing
uv run --withwith system interpreters at all. I think we can consider that, but the issue highlighted thatuv run --withfor a system interpreter is broken if the base interpreter has custom site packages. This generalizes beyond system interpreters so we should probably fix our overlays.