Conversation
3d3fb04 to
0b2e67a
Compare
I do not want these tests to silently start using PyPI
zanieb
commented
Aug 6, 2025
8ac4e7c to
53834f2
Compare
53834f2 to
7cec1ac
Compare
59beed0 to
ab3a7c0
Compare
6c5e1d1 to
a2e92b8
Compare
a2e92b8 to
dec63bb
Compare
dec63bb to
938efb3
Compare
938efb3 to
83b1950
Compare
83b1950 to
255e0f5
Compare
51438cc to
ea24e55
Compare
konstin
approved these changes
Aug 7, 2025
| .with_filtered_python_names() | ||
| .with_filtered_virtualenv_bin() | ||
| .with_filtered_exe_suffix() | ||
| .with_filter(user_scheme_bin_filter()); |
Member
There was a problem hiding this comment.
Why are we using with_filter here but let mut filters = context.filters(); in the rest of the tests?
Member
Author
There was a problem hiding this comment.
I think it's a better pattern — I intend to update the other cases later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test cases to unblock
find_uv_binto locate uv in the base prefix #14181find_uv_binand add a better error message #14182--prefixand--withinstallations infind_uv_bin#14184We use a package with a symlink to the Python module to get a mock installation of uv without building (or packaging) the uv binary. This lets us test real patterns like
uv pip install --prefixwithout encoding logic about where things are placed during those installs.