Skip to content

Add test cases for find_uv_bin#15110

Merged
zanieb merged 18 commits intomainfrom
zb/test-find-uv-bin
Aug 7, 2025
Merged

Add test cases for find_uv_bin#15110
zanieb merged 18 commits intomainfrom
zb/test-find-uv-bin

Conversation

@zanieb
Copy link
Copy Markdown
Member

@zanieb zanieb commented Aug 6, 2025

Adds test cases to unblock

We use a package with a symlink to the Python module to get a mock installation of uv without building (or packaging) the uv binary. This lets us test real patterns like uv pip install --prefix without encoding logic about where things are placed during those installs.

@zanieb zanieb added the testing Internal testing of behavior label Aug 6, 2025
@zanieb zanieb temporarily deployed to uv-test-registries August 6, 2025 15:21 — with GitHub Actions Inactive
@zanieb zanieb temporarily deployed to uv-test-registries August 6, 2025 15:28 — with GitHub Actions Inactive
@zanieb zanieb force-pushed the zb/test-find-uv-bin branch from 3d3fb04 to 0b2e67a Compare August 6, 2025 15:29
@zanieb zanieb temporarily deployed to uv-test-registries August 6, 2025 15:31 — with GitHub Actions Inactive
zanieb added 2 commits August 6, 2025 10:33
I do not want these tests to silently start using PyPI
@zanieb zanieb temporarily deployed to uv-test-registries August 6, 2025 15:45 — with GitHub Actions Inactive
@zanieb zanieb temporarily deployed to uv-test-registries August 6, 2025 15:50 — with GitHub Actions Inactive
@zanieb zanieb temporarily deployed to uv-test-publish August 6, 2025 15:51 — with GitHub Actions Inactive
@zanieb zanieb temporarily deployed to uv-test-registries August 6, 2025 16:18 — with GitHub Actions Inactive
@zanieb zanieb temporarily deployed to uv-test-publish August 6, 2025 16:18 — with GitHub Actions Inactive
@zanieb zanieb force-pushed the zb/test-find-uv-bin branch from 8ac4e7c to 53834f2 Compare August 6, 2025 16:25
@zanieb zanieb temporarily deployed to uv-test-registries August 6, 2025 16:32 — with GitHub Actions Inactive
@zanieb zanieb temporarily deployed to uv-test-publish August 6, 2025 16:32 — with GitHub Actions Inactive
@zanieb zanieb force-pushed the zb/test-find-uv-bin branch from 53834f2 to 7cec1ac Compare August 6, 2025 16:44
@zanieb zanieb force-pushed the zb/test-find-uv-bin branch from 59beed0 to ab3a7c0 Compare August 6, 2025 21:26
@zanieb zanieb temporarily deployed to uv-test-registries August 6, 2025 21:28 — with GitHub Actions Inactive
@zanieb zanieb temporarily deployed to uv-test-publish August 6, 2025 21:29 — with GitHub Actions Inactive
@zanieb zanieb temporarily deployed to uv-test-registries August 6, 2025 21:42 — with GitHub Actions Inactive
@zanieb zanieb temporarily deployed to uv-test-registries August 6, 2025 22:00 — with GitHub Actions Inactive
@zanieb zanieb force-pushed the zb/test-find-uv-bin branch from 6c5e1d1 to a2e92b8 Compare August 6, 2025 22:14
@zanieb zanieb temporarily deployed to uv-test-registries August 6, 2025 22:16 — with GitHub Actions Inactive
@zanieb zanieb changed the base branch from main to feature/find-uv-bin August 6, 2025 22:17
@zanieb zanieb force-pushed the zb/test-find-uv-bin branch from a2e92b8 to dec63bb Compare August 6, 2025 22:34
@zanieb zanieb temporarily deployed to uv-test-registries August 6, 2025 22:36 — with GitHub Actions Inactive
@zanieb zanieb force-pushed the zb/test-find-uv-bin branch from dec63bb to 938efb3 Compare August 7, 2025 00:45
@zanieb zanieb temporarily deployed to uv-test-registries August 7, 2025 00:47 — with GitHub Actions Inactive
@zanieb zanieb force-pushed the zb/test-find-uv-bin branch from 938efb3 to 83b1950 Compare August 7, 2025 01:04
@zanieb zanieb temporarily deployed to uv-test-registries August 7, 2025 01:06 — with GitHub Actions Inactive
@zanieb zanieb force-pushed the zb/test-find-uv-bin branch from 83b1950 to 255e0f5 Compare August 7, 2025 01:24
@zanieb zanieb temporarily deployed to uv-test-registries August 7, 2025 01:25 — with GitHub Actions Inactive
@zanieb zanieb temporarily deployed to uv-test-registries August 7, 2025 02:21 — with GitHub Actions Inactive
@zanieb zanieb force-pushed the zb/test-find-uv-bin branch from 51438cc to ea24e55 Compare August 7, 2025 03:10
@zanieb zanieb temporarily deployed to uv-test-registries August 7, 2025 03:12 — with GitHub Actions Inactive
@zanieb zanieb marked this pull request as ready for review August 7, 2025 03:55
.with_filtered_python_names()
.with_filtered_virtualenv_bin()
.with_filtered_exe_suffix()
.with_filter(user_scheme_bin_filter());
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using with_filter here but let mut filters = context.filters(); in the rest of the tests?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a better pattern — I intend to update the other cases later.

@zanieb zanieb changed the base branch from feature/find-uv-bin to main August 7, 2025 12:13
@zanieb zanieb merged commit 278295e into main Aug 7, 2025
93 checks passed
@zanieb zanieb deleted the zb/test-find-uv-bin branch August 7, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Internal testing of behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants