Skip to content

Add Python versions to markers implied from wheels#14913

Merged
zanieb merged 1 commit intomainfrom
zb/python-implied-markers
Aug 5, 2025
Merged

Add Python versions to markers implied from wheels#14913
zanieb merged 1 commit intomainfrom
zb/python-implied-markers

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented Jul 26, 2025

Looking into #14836

This does resolve the issue, if the user adds python_version == '3.8.*' to the required-environments.

@zanieb zanieb temporarily deployed to uv-test-registries July 26, 2025 04:08 — with GitHub Actions Inactive
@zanieb zanieb force-pushed the zb/python-implied-markers branch from 050825c to d64be09 Compare July 29, 2025 21:44
@zanieb zanieb temporarily deployed to uv-test-registries July 29, 2025 21:47 — with GitHub Actions Inactive
@zanieb
Copy link
Member Author

zanieb commented Jul 29, 2025

In contrast to platform markers, I think we might always want to enforce that the Python version markers are satisfied by the implied markers, even if they're not defined as a required-environment. However, I'm curious if we should land this pull request first since it's an incremental improvement and we can get a sense of whether or not this has unintended effects? Then we can land doing this by default as a subsequent change?

@charliermarsh
Copy link
Member

Yeah, I think we should always enforce this, unlike platform markers.

I'm okay shipping this first if you'd prefer.

@charliermarsh
Copy link
Member

The only downside here is that the lockfile markers get unnecessarily more-complex in some cases, as you can see from the diffs.

@zanieb
Copy link
Member Author

zanieb commented Jul 30, 2025

Agree it's a bummer the markers are more complex. I guess some of that noise would be cut out if we treated platform_python_implementation differently. I think it's sort of fine though.

@zanieb zanieb force-pushed the zb/python-implied-markers branch from d64be09 to 3199671 Compare July 30, 2025 14:58
@zanieb zanieb temporarily deployed to uv-test-registries July 30, 2025 14:59 — with GitHub Actions Inactive
@zanieb zanieb force-pushed the zb/python-implied-markers branch from 3199671 to c145920 Compare July 30, 2025 17:52
@zanieb zanieb temporarily deployed to uv-test-registries July 30, 2025 17:55 — with GitHub Actions Inactive
@zanieb zanieb marked this pull request as ready for review July 30, 2025 23:03
@zanieb
Copy link
Member Author

zanieb commented Jul 30, 2025

Yeah, I think we should always enforce this, unlike platform markers.

I'll try to look into that in the next week or so.

@zanieb zanieb added the bug Something isn't working label Aug 4, 2025
@zanieb zanieb merged commit 1fb0fa0 into main Aug 5, 2025
92 checks passed
@zanieb zanieb deleted the zb/python-implied-markers branch August 5, 2025 19:52
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Aug 6, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.8.4` -> `0.8.5` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>astral-sh/uv (astral-sh/uv)</summary>

### [`v0.8.5`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#085)

[Compare Source](astral-sh/uv@0.8.4...0.8.5)

##### Enhancements

- Enable `uv run` with a GitHub Gist ([#&#8203;15058](astral-sh/uv#15058))
- Improve HTTP response caching log messages ([#&#8203;15067](astral-sh/uv#15067))
- Show wheel tag hints in install plan ([#&#8203;15066](astral-sh/uv#15066))
- Support installing additional executables in `uv tool install` ([#&#8203;14014](astral-sh/uv#14014))

##### Preview features

- Enable extra build dependencies to 'match runtime' versions ([#&#8203;15036](astral-sh/uv#15036))
- Remove duplicate `extra-build-dependencies` warnings for `uv pip` ([#&#8203;15088](astral-sh/uv#15088))
- Use "option" instead of "setting" in `pylock` warning ([#&#8203;15089](astral-sh/uv#15089))
- Respect extra build requires when reading from wheel cache ([#&#8203;15030](astral-sh/uv#15030))
- Preserve lowered extra build dependencies ([#&#8203;15038](astral-sh/uv#15038))

##### Bug fixes

- Add Python versions to markers implied from wheels ([#&#8203;14913](astral-sh/uv#14913))
- Ensure consistent indentation when adding dependencies ([#&#8203;14991](astral-sh/uv#14991))
- Fix handling of `python-preference = system` when managed interpreters are on the PATH ([#&#8203;15059](astral-sh/uv#15059))
- Fix symlink preservation in virtual environment creation ([#&#8203;14933](astral-sh/uv#14933))
- Gracefully handle entrypoint permission errors ([#&#8203;15026](astral-sh/uv#15026))
- Include wheel hashes from local Simple indexes ([#&#8203;14993](astral-sh/uv#14993))
- Prefer system Python installations over managed ones when `--system` is used ([#&#8203;15061](astral-sh/uv#15061))
- Remove retry wrapper when matching on error kind ([#&#8203;14996](astral-sh/uv#14996))
- Revert `h2` upgrade ([#&#8203;15079](astral-sh/uv#15079))

##### Documentation

- Improve visibility of copy and line separator in dark mode ([#&#8203;14987](astral-sh/uv#14987))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS41Mi4yIiwidXBkYXRlZEluVmVyIjoiNDEuNTIuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments