Add troubleshooting section to benchmarks guide #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurntSushi
reviewed
Feb 16, 2024
BENCHMARKS.md
Outdated
|
|
||
| ### Flaky benchmarks | ||
|
|
||
| If you're seeing high variance in your benchmarks, then it's likely that you're running into throttling or DDoS prevention from your ISP. In that case, ISPs forcefully terminate TCP connections with a TCP reset. We believe this is due to the benchmarks making the exact same requests in a very short time (especially true for `uv`). A possible workaround is to connect to VPN to bypass your ISPs filtering mechanism. |
There was a problem hiding this comment.
Could you add a qualifying word here to indicate that this is about the cold benchmarks and not the warm ones? The warm benchmarks shouldn't suffer from the same problem. Maybe just say, "in your cold benchmarks" or "benchmarks that aren't using a cache."
MichaReiser
force-pushed
the
benchmark-troubleshooting
branch
from
f06f60f
to
c7eeb2d
Compare
zanieb
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It took me a while to figure out why the benchmarks are extremelly flaky (and slow) on my machine.
I documented my finding in the benchmarks.md file in case someone else runs into the same problems as I