Parse -r and -c entries as relative to containing file
#1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/rel
branch
2 times, most recently
from
9ffa7c4
to
4443e50
Compare
charliermarsh
commented
Feb 16, 2024
|
|
||
| /// Resolve nested `-r` requirements files with relative paths. | ||
| #[test] | ||
| fn compile_relative_subfile() -> Result<()> { |
There was a problem hiding this comment.
Also verified that this fails on main.
charliermarsh
force-pushed
the
charlie/rel
branch
from
4443e50
to
1fc8e3c
Compare
charliermarsh
force-pushed
the
charlie/rel
branch
from
1fc8e3c
to
2be5a10
Compare
zanieb
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In a
requirements.txtfile, it turns out that the-cand-rentries should be interpreted as relative to the file in which they're declared, while the-eentries should be interpreted as relative to the current working directory, no matter where they're defined.Previously, we always used the current working directory; now, we use the declaring file's directory for
-cand-r.Closes #1367.
Closes #1416.