Fix broken URLs parsed from relative paths in registries #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/relative-html
branch
from
2b30dfb
to
da7fc90
Compare
zanieb
changed the title
SimpleHtml test case for AWS CodeArtifact
zanieb
force-pushed
the
zb/relative-html
branch
from
311dc25
to
0c50ed5
Compare
zanieb
force-pushed
the
zb/relative-html
branch
from
0c50ed5
to
829a1ed
Compare
zanieb
changed the title
zanieb
commented
Feb 16, 2024
Comment on lines
-39
to
48
| #[error("Failed to parse URL: `{original}`")] | ||
| pub struct JoinRelativeError { | ||
| original: String, | ||
| source: url::ParseError, | ||
| pub enum JoinRelativeError { | ||
| #[error("Failed to parse URL: `{original}`")] | ||
| ParseError { | ||
| original: String, | ||
| source: url::ParseError, | ||
| }, | ||
| } |
There was a problem hiding this comment.
I changed this when I was handling another error kind in here. Think it makes sense to leave it for the future, I prefer enum error wrappers.
charliermarsh
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1388
Fixes incorrect handling of relative paths returned by indexes without an explicit
<base>.Url.joinwill drop the last segment in an url e.g.http://foo/bar->http://foo/bazif there is not a trailing slash but what we want ishttp://foo/bar/baz. We don't add the trailing/inbase_url_join_relativebecause flat indexes arehttp://foo/bar.htmland we wantbar.htmlto be replaced.