Fix broken URLs parsed from relative paths in registries #1413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1388
Fixes incorrect handling of relative paths returned by indexes without an explicit
<base>
.Url.join
will drop the last segment in an url e.g.http://foo/bar
->http://foo/baz
if there is not a trailing slash but what we want ishttp://foo/bar/baz
. We don't add the trailing/
inbase_url_join_relative
because flat indexes arehttp://foo/bar.html
and we wantbar.html
to be replaced.