Merged
Conversation
zanieb
force-pushed
the
zb/ruff-fix
branch
3 times, most recently
from
a18b2c8 to
456d726
Compare
konstin
approved these changes
Jun 17, 2025
Member
Author
|
This shouldn't pass without #14108 but does? — edit: this is because we incorrectly excluded the |
| # location. So in newer versions, we also write a dedicated flag to indicate standalone builds. | ||
| "standalone": sysconfig.get_config_var("prefix") == "/install" or bool(sysconfig.get_config_var("PYTHON_BUILD_STANDALONE")), | ||
| "standalone": sysconfig.get_config_var("prefix") == "/install" | ||
| or bool(sysconfig.get_config_var("PYTHON_BUILD_STANDALONE")), |
Member
There was a problem hiding this comment.
Can we parenthesize this?
Member
Author
There was a problem hiding this comment.
Yeah, that formatting drives me crazy :)
zanieb
force-pushed
the
zb/ruff-fix
branch
3 times, most recently
from
e830252 to
f5605f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.