Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid import contextlib in _virtualenv #1406

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Avoid import contextlib in _virtualenv #1406

merged 1 commit into from
Feb 16, 2024

Conversation

hauntsaninja
Copy link
Contributor

No need to pay 3ms on basically every Python invocation. I opened a PR upstream last week: pypa/virtualenv#2688

@hauntsaninja
Avoid import contextlib in _virtualenv
1c93a1f 
No need to pay 3ms on basically every Python invocation.
I opened a PR upstream last week: pypa/virtualenv#2688
@charliermarsh
Copy link
Member

Nice, thank you.

zanieb
zanieb approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zanieb zanieb added the performance Potential performance improvement label Feb 16, 2024
@charliermarsh charliermarsh merged commit e9d82cf into astral-sh:main Feb 16, 2024
7 checks passed
@hauntsaninja hauntsaninja deleted the avoid-contextlib branch February 16, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
performance Potential performance improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hauntsaninja @charliermarsh @zanieb