Refactor version handling in self_update to report upgradable version#14027
Open
miried wants to merge 1 commit intoastral-sh:mainfrom
Open
Refactor version handling in self_update to report upgradable version#14027miried wants to merge 1 commit intoastral-sh:mainfrom
miried wants to merge 1 commit intoastral-sh:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change is an improvement on the
dry_runfunctionality introduced in #9829. It now shows the version that would be upgraded to.Note that despite its name,
updater.is_update_needed()does not only check the version numbers, but it also checks if the executable can be actually upgraded. This is reflected in the wording of the new message. See https://docs.rs/axoupdater/0.9.0/axoupdater/struct.AxoUpdater.html#method.is_update_neededTest Plan
Tested locally