Update error message for module conflict hint#13889
Closed
zanieb wants to merge 1 commit intokonsti/warn-on-module-conflictsfrom
Closed
Update error message for module conflict hint#13889zanieb wants to merge 1 commit intokonsti/warn-on-module-conflictsfrom
zanieb wants to merge 1 commit intokonsti/warn-on-module-conflictsfrom
Conversation
zanieb
commented
Jun 6, 2025
| Consider removing either {} ({}) or {} ({}).", | ||
| module.simplified_display(), | ||
| wheel_a.name, | ||
| wheel_a, |
Member
Author
There was a problem hiding this comment.
Discussion on inclusion of the wheel filename is happening at #13437 (comment)
Member
There was a problem hiding this comment.
The error should by itself contain enough information to track down the problem, so I would like it to at least contain the versions.
Member
Author
There was a problem hiding this comment.
👍 I'm happy to hand this off to you, unless you want me to write the version display.
Member
Author
|
I believe this was incorporated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review for #13437