Skip to content

Only show the first match per platform (and architecture) by default in uv python list #13721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025
Merged

Only show the first match per platform (and architecture) by default in uv python list #13721

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ddc643
only conditionally consider os/arch when filtering downloads
Gankra May 29, 2025
59dbcb3
fmt
Gankra May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions crates/uv/src/commands/python/list.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,16 +167,20 @@ pub(crate) async fn list(
}
}

// Only show the latest patch version for each download unless all were requested
// Only show the latest patch version for each download unless all were requested.
//
// We toggle off platforms/arches based unless all_platforms/all_arches because
// we want to only show the "best" option for each version by default, even
// if e.g. the x86_32 build would also work on x86_64.
if !matches!(kind, Kind::System) {
if let [major, minor, ..] = *key.version().release() {
if !seen_minor.insert((
*key.os(),
all_platforms.then_some(*key.os()),
major,
minor,
key.variant(),
key.implementation(),
*key.arch(),
all_arches.then_some(*key.arch()),
*key.libc(),
)) {
if matches!(kind, Kind::Download) && !all_versions {
Expand All @@ -186,13 +190,13 @@ pub(crate) async fn list(
}
if let [major, minor, patch] = *key.version().release() {
if !seen_patch.insert((
*key.os(),
all_platforms.then_some(*key.os()),
major,
minor,
patch,
key.variant(),
key.implementation(),
*key.arch(),
all_arches.then_some(*key.arch()),
key.libc(),
)) {
if matches!(kind, Kind::Download) {
Expand Down
Loading