Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix diagram alignment #1354

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Fix diagram alignment #1354

merged 1 commit into from
Feb 15, 2024

Conversation

ysndr
Copy link
Contributor

@ysndr ysndr commented Feb 15, 2024

Drive by alignment PR for the trait structure diagram

zanieb
zanieb approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks! That's my bad for doing a global replace :)

@zanieb zanieb added the documentation Improvements or additions to documentation label Feb 15, 2024
@zanieb
Copy link
Member

zanieb commented Feb 15, 2024 •
edited
Loading

You also win the first external contribution award <3 (edit: oh no just saw #1345)

@zanieb zanieb merged commit 36544e1 into astral-sh:main Feb 15, 2024
7 checks passed
@ysndr
Copy link
Contributor Author

ysndr commented Feb 15, 2024

hah, they beat me to it :D
Cool stuff I'm seeing here though, good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ysndr @zanieb