Skip to content

Fix display of HTTP responses in trace logs for retry of errors #13339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zanieb merged 2 commits into from
May 8, 2025
Merged

Fix display of HTTP responses in trace logs for retry of errors #13339

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4af1f4b
Use `WrappedReqwestError` instead of `reqwest::Error` for retry logs
zanieb May 7, 2025
64f66e5
Fix formatting
zanieb May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions crates/uv-client/src/base_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,14 +481,10 @@ impl RetryableStrategy for UvRetryableStrategy {
/// These cases should be safe to retry with [`Retryable::Transient`].
pub fn is_extended_transient_error(err: &dyn Error) -> bool {
// First, try to show a nice trace log
if let Some((Some(status), Some(url))) = find_source::<reqwest::Error>(&err)
if let Some((Some(status), Some(url))) = find_source::<crate::WrappedReqwestError>(&err)
.map(|request_err| (request_err.status(), request_err.url()))
{
let status = status
.canonical_reason()
.map(|reason| format!(" HTTP {status} {reason} "))
.unwrap_or_else(|| format!(" HTTP {status} "));
trace!("Considering retry of {status} for {url}");
trace!("Considering retry of response HTTP {status} for {url}");
} else {
trace!("Considering retry of error: {err:?}");
}
Expand Down
Loading