ProgressReporter: align progress bars by largest name length by eduardorittner · Pull Request #13266 · astral-sh/uv

eduardorittner · 2025-05-02T14:06:35Z

Summary

Related to #12492

This change makes all progress bars vertically aligned. This is still a WIP and so is not complete, in the current design I store max_len in BarState and update it on every on_request_start, however this is problematic since order matters, and if the largest name is not sent first, the alignment is not complete. To mitigate this we'd probably have to update all previous bars by "iterating" through the bars field in BarState and update all request bars.

Below is an image of what happens when the largest name (nvidia-cusparselt-cu12) is not the first (in this case, it was the second to last).

Test Plan

There are currently no tests, and I'm not sure how to design them since from what I gather the uv_snapshot facilities record the final output, not the intermediate stages.

ibraheemdev

Just left a couple of nits. I think you're right that we need to update previous bars to keep things aligned, but that shouldn't be too hard.

It might be a little odd if the padding changes for all bars dynamically, maybe we should at least increase the default from 10?

crates/uv/src/commands/reporters.rs

ibraheemdev · 2025-05-09T17:41:33Z

crates/uv/src/commands/reporters.rs

        state.sizes.insert(position, size.unwrap_or(0));
+        state.update_max_len(name.len());

        let progress = multi_progress.insert(


Right here is where you should be able to iterate through the multi_progress and realign everything.

This is what I'm having a hard time with, indicatif's MultiProgress only has an insert method, with no way of iterating or getting/setting specific values inside it. Which means I should probably be iterating through a field in BarState? But I'm not sure which one, since IDs are only stored in maps, not vectors. Maybe I could figure out from BarState.headers and BarState.id, how many headers are downloads (BarState.id - BarState.headers?) and then iterate from BarState.id - BarState.headers to BarState.id accessing the relevant bar in BarState.bars.

I just did the dumb thing and iterated through 0..BarState.id and it seems to work, I'm not sure if there's a situation where it breaks or does something unexpected.

--

konstin · 2025-05-13T18:48:14Z

Hi, and sorry for the late review. Could you change the code so that when we have a new longest progress bar, it updates all running progress bars to the new template with the new length (as you suggested), to avoid a pattern like below?

eduardorittner · 2025-05-14T13:20:25Z

Thank you for all the comments and suggestions! I'm having a busy month with school and work but will work on this when I have time 😁

eduardorittner · 2025-05-14T20:23:03Z

I mentioned this in the PR description, but do you have any ideas on how to test this feature? Since we care about the intermediate state while downloads are happening (dynamically adjusting bar length) not only the final one, should we have several snapshots of the output? How can we simulate downloads without actually hitting the network?

eduardorittner · 2025-05-14T20:23:45Z

It might be a little odd if the padding changes for all bars dynamically, maybe we should at least increase the default from 10?

Changed it to 20, let me know what you think!

eduardorittner · 2025-05-14T20:29:47Z

Another question I have is if I should write similar logic in on_build_start? If so, any tips on what/how to build with uv? I've only ever downloaded packages with it so I'm unsure

eduardorittner · 2025-05-14T20:36:39Z

Hi, and sorry for the late review. Could you change the code so that when we have a new longest progress bar, it updates all running progress bars to the new template with the new length (as you suggested), to avoid a pattern like below?

Also which package are you downloading here? I wanted to test this with a lot of packages but torch is only pulling like 10 dependencies

konstin · 2025-05-15T06:31:09Z

I mentioned this in the PR description, but do you have any ideas on how to test this feature? Since we care about the intermediate state while downloads are happening (dynamically adjusting bar length) not only the final one, should we have several snapshots of the output? How can we simulate downloads without actually hitting the network?

We test this manually part manually, we don't have snapshots for non-static text.

Another question I have is if I should write similar logic in on_build_start? If so, any tips on what/how to build with uv? I've only ever downloaded packages with it so I'm unsure

The builds use a spinner instead of a progress bar (we can't tell how long they will take), so this is only relevant for on_*_progress bars.

Also which package are you downloading here? I wanted to test this with a lot of packages but torch is only pulling like 10 dependencies

I'm using

uv venv -p 3.11 && cargo run pip install -r scripts/requirements/transformers-extras.in

sometimes with --no-cache.

konstin · 2025-05-15T07:12:39Z

I've updated the code to use an enum to only apply this logic to numeric progress while skipping progress spinners, and I've rebased for the merge conflict with main.

Screencast.from.2025-05-15.09-11-13.webm

## 0.7.5 ### Bug fixes - Support case-sensitive module discovery in the build backend ([#13468](astral-sh/uv#13468)) - Bump Simple cache bucket to v16 ([#13498](astral-sh/uv#13498)) - Don't error when the script is too short for the buffer ([#13488](astral-sh/uv#13488)) - Add missing word in "script not supported" error ([#13483](astral-sh/uv#13483)) ## 0.7.4 ### Enhancements - Add more context to external errors ([#13351](astral-sh/uv#13351)) - Align indentation of long arguments ([#13394](astral-sh/uv#13394)) - Preserve order of dependencies which are sorted naively ([#13334](astral-sh/uv#13334)) - Align progress bars by largest name length ([#13266](astral-sh/uv#13266)) - Reinstall local packages in `uv add` ([#13462](astral-sh/uv#13462)) - Rename `--raw-sources` to `--raw` ([#13348](astral-sh/uv#13348)) - Show 'Downgraded' when `self update` is used to install an older version ([#13340](astral-sh/uv#13340)) - Suggest `uv self update` if required uv version is newer ([#13305](astral-sh/uv#13305)) - Add 3.14 beta images to uv Docker images ([#13390](astral-sh/uv#13390)) - Add comma after "i.e." in Conda environment error ([#13423](astral-sh/uv#13423)) - Be more precise in unpinned packages warning ([#13426](astral-sh/uv#13426)) - Fix detection of sorted dependencies when include-group is used ([#13354](astral-sh/uv#13354)) - Fix display of HTTP responses in trace logs for retry of errors ([#13339](astral-sh/uv#13339)) - Log skip reasons during Python installation key interpreter match checks ([#13472](astral-sh/uv#13472)) - Redact credentials when displaying URLs ([#13333](astral-sh/uv#13333)) ### Bug fixes - Avoid erroring on `pylock.toml` dependency entries ([#13384](astral-sh/uv#13384)) - Avoid panics for cannot-be-a-base URLs ([#13406](astral-sh/uv#13406)) - Ensure cached realm credentials are applied if no password is found for index URL ([#13463](astral-sh/uv#13463)) - Fix `.tgz` parsing to respect true extension ([#13382](astral-sh/uv#13382)) - Fix double self-dependency ([#13366](astral-sh/uv#13366)) - Reject `pylock.toml` in `uv add -r` ([#13421](astral-sh/uv#13421)) - Retain dot-separated wheel tags during cache prune ([#13379](astral-sh/uv#13379)) - Retain trailing comments after PEP 723 metadata block ([#13460](astral-sh/uv#13460)) ### Documentation - Use "export" instead of "install" in `uv export` arguments ([#13430](astral-sh/uv#13430)) - Remove extra newline ([#13461](astral-sh/uv#13461)) ### Preview features - Build backend: Normalize glob paths ([#13465](astral-sh/uv#13465))

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.7.3` -> `0.7.5` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.7.5`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#075) [Compare Source](astral-sh/uv@0.7.4...0.7.5) ##### Bug fixes - Support case-sensitive module discovery in the build backend ([#13468](astral-sh/uv#13468)) - Bump Simple cache bucket to v16 ([#13498](astral-sh/uv#13498)) - Don't error when the script is too short for the buffer ([#13488](astral-sh/uv#13488)) - Add missing word in "script not supported" error ([#13483](astral-sh/uv#13483)) ### [`v0.7.4`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#074) [Compare Source](astral-sh/uv@0.7.3...0.7.4) ##### Enhancements - Add more context to external errors ([#13351](astral-sh/uv#13351)) - Align indentation of long arguments ([#13394](astral-sh/uv#13394)) - Preserve order of dependencies which are sorted naively ([#13334](astral-sh/uv#13334)) - Align progress bars by largest name length ([#13266](astral-sh/uv#13266)) - Reinstall local packages in `uv add` ([#13462](astral-sh/uv#13462)) - Rename `--raw-sources` to `--raw` ([#13348](astral-sh/uv#13348)) - Show 'Downgraded' when `self update` is used to install an older version ([#13340](astral-sh/uv#13340)) - Suggest `uv self update` if required uv version is newer ([#13305](astral-sh/uv#13305)) - Add 3.14 beta images to uv Docker images ([#13390](astral-sh/uv#13390)) - Add comma after "i.e." in Conda environment error ([#13423](astral-sh/uv#13423)) - Be more precise in unpinned packages warning ([#13426](astral-sh/uv#13426)) - Fix detection of sorted dependencies when include-group is used ([#13354](astral-sh/uv#13354)) - Fix display of HTTP responses in trace logs for retry of errors ([#13339](astral-sh/uv#13339)) - Log skip reasons during Python installation key interpreter match checks ([#13472](astral-sh/uv#13472)) - Redact credentials when displaying URLs ([#13333](astral-sh/uv#13333)) ##### Bug fixes - Avoid erroring on `pylock.toml` dependency entries ([#13384](astral-sh/uv#13384)) - Avoid panics for cannot-be-a-base URLs ([#13406](astral-sh/uv#13406)) - Ensure cached realm credentials are applied if no password is found for index URL ([#13463](astral-sh/uv#13463)) - Fix `.tgz` parsing to respect true extension ([#13382](astral-sh/uv#13382)) - Fix double self-dependency ([#13366](astral-sh/uv#13366)) - Reject `pylock.toml` in `uv add -r` ([#13421](astral-sh/uv#13421)) - Retain dot-separated wheel tags during cache prune ([#13379](astral-sh/uv#13379)) - Retain trailing comments after PEP 723 metadata block ([#13460](astral-sh/uv#13460)) ##### Documentation - Use "export" instead of "install" in `uv export` arguments ([#13430](astral-sh/uv#13430)) - Remove extra newline ([#13461](astral-sh/uv#13461)) ##### Preview features - Build backend: Normalize glob paths ([#13465](astral-sh/uv#13465)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

zanieb added the cli Related to the command line interface label May 9, 2025

zanieb requested a review from konstin May 9, 2025 14:53

zanieb assigned konstin May 9, 2025

ibraheemdev reviewed May 9, 2025

View reviewed changes

crates/uv/src/commands/reporters.rs Outdated Show resolved Hide resolved

crates/uv/src/commands/reporters.rs Outdated Show resolved Hide resolved

ibraheemdev reviewed May 9, 2025

View reviewed changes

konstin reviewed May 13, 2025

View reviewed changes

-- Outdated Show resolved Hide resolved

eduardorittner force-pushed the align-prog branch from 05d14d8 to 9f5a84f Compare May 14, 2025 20:13

eduardorittner force-pushed the align-prog branch 2 times, most recently from f737465 to db56d61 Compare May 14, 2025 20:28

eduardorittner marked this pull request as ready for review May 14, 2025 20:29

eduardorittner force-pushed the align-prog branch from db56d61 to 9f418b3 Compare May 14, 2025 20:38

eduardorittner and others added 3 commits May 15, 2025 09:07

ProgressReporter: align progress bars by largest name length

a1f6d46

Refactor

0b8d185

Don't update the template for spinners

dc4f423

konstin force-pushed the align-prog branch from c40db6f to 3c792c0 Compare May 15, 2025 07:08

konstin added 2 commits May 15, 2025 09:09

Use enum for spinner types

53bf453

Use real max len default again

139a209

konstin force-pushed the align-prog branch from 3c792c0 to 139a209 Compare May 15, 2025 07:09

konstin merged commit 2d4d93a into astral-sh:main May 15, 2025
86 checks passed

BrewTestBot mentioned this pull request May 15, 2025

uv 0.7.4 Homebrew/homebrew-core#223581

Merged

Conversation

eduardorittner commented May 2, 2025

Summary

Test Plan

Uh oh!

ibraheemdev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ibraheemdev May 9, 2025

Choose a reason for hiding this comment

Uh oh!

eduardorittner May 14, 2025

Choose a reason for hiding this comment

Uh oh!

eduardorittner May 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

konstin commented May 13, 2025

Uh oh!

eduardorittner commented May 14, 2025

Uh oh!

eduardorittner commented May 14, 2025

Uh oh!

eduardorittner commented May 14, 2025

Uh oh!

eduardorittner commented May 14, 2025

Uh oh!

eduardorittner commented May 14, 2025

Uh oh!

konstin commented May 15, 2025

Uh oh!

konstin commented May 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ibraheemdev left a comment •

edited

Loading