Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions crates/uv-distribution-types/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -844,6 +844,28 @@ impl Name for Dist {
}
}

impl Name for CompatibleDist<'_> {
fn name(&self) -> &PackageName {
match self {
CompatibleDist::InstalledDist(dist) => dist.name(),
CompatibleDist::SourceDist {
sdist,
prioritized: _,
} => sdist.name(),
CompatibleDist::CompatibleWheel {
wheel,
priority: _,
prioritized: _,
} => wheel.name(),
CompatibleDist::IncompatibleWheel {
sdist,
wheel: _,
prioritized: _,
} => sdist.name(),
}
}
}

impl DistributionMetadata for RegistryBuiltWheel {
fn version_or_url(&self) -> VersionOrUrlRef {
VersionOrUrlRef::Version(&self.filename.version)
Expand Down
30 changes: 26 additions & 4 deletions crates/uv-resolver/src/resolver/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1320,7 +1320,7 @@ impl<InstalledPackages: InstalledPackagesProvider> ResolverState<InstalledPackag
candidate.choice_kind(),
filename,
);
self.visit_candidate(&candidate, dist, package, pins, request_sink)?;
self.visit_candidate(&candidate, dist, package, name, pins, request_sink)?;

let version = candidate.version().clone();
Ok(Some(ResolverVersion::Unforked(version)))
Expand Down Expand Up @@ -1480,7 +1480,14 @@ impl<InstalledPackages: InstalledPackagesProvider> ResolverState<InstalledPackag
base_candidate.choice_kind(),
filename,
);
self.visit_candidate(&base_candidate, base_dist, package, pins, request_sink)?;
self.visit_candidate(
&base_candidate,
base_dist,
package,
name,
pins,
request_sink,
)?;

return Ok(Some(ResolverVersion::Unforked(
base_candidate.version().clone(),
Expand Down Expand Up @@ -1527,8 +1534,15 @@ impl<InstalledPackages: InstalledPackagesProvider> ResolverState<InstalledPackag
.collect::<Vec<_>>()
.join(", ")
);
self.visit_candidate(candidate, dist, package, pins, request_sink)?;
self.visit_candidate(&base_candidate, base_dist, package, pins, request_sink)?;
self.visit_candidate(candidate, dist, package, name, pins, request_sink)?;
self.visit_candidate(
&base_candidate,
base_dist,
package,
name,
pins,
request_sink,
)?;

let forks = vec![
VersionFork {
Expand All @@ -1551,6 +1565,7 @@ impl<InstalledPackages: InstalledPackagesProvider> ResolverState<InstalledPackag
candidate: &Candidate,
dist: &CompatibleDist,
package: &PubGrubPackage,
name: &PackageName,
pins: &mut FilePins,
request_sink: &Sender<Request>,
) -> Result<(), ResolveError> {
Expand All @@ -1562,6 +1577,13 @@ impl<InstalledPackages: InstalledPackagesProvider> ResolverState<InstalledPackag
if matches!(&**package, PubGrubPackageInner::Package { .. }) {
if self.dependency_mode.is_transitive() {
if self.index.distributions().register(candidate.version_id()) {
if name != dist.name() {
return Err(ResolveError::MismatchedPackageName {
request: "distribution",
expected: name.clone(),
actual: dist.name().clone(),
});
}
// Verify that the package is allowed under the hash-checking policy.
if !self
.hasher
Expand Down
34 changes: 34 additions & 0 deletions crates/uv/tests/it/pip_install.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11127,3 +11127,37 @@ fn pep_751_multiple_sources() -> Result<()> {

Ok(())
}

/// Test that uv doesn't hang if an index returns a distribution for the wrong package.
#[tokio::test]
async fn bogus_redirect() -> Result<()> {
let context = TestContext::new("3.12");

let redirect_server = MockServer::start().await;

// Configure a bogus redirect where for all packages, anyio is returned.
Mock::given(method("GET"))
.respond_with(
ResponseTemplate::new(302).insert_header("Location", "https://pypi.org/simple/anyio/"),
)
.mount(&redirect_server)
.await;

uv_snapshot!(
context
.pip_install()
.arg("--default-index")
.arg(redirect_server.uri())
.arg("sniffio"),
@r"
success: false
exit_code: 2
----- stdout -----

----- stderr -----
error: The index returned metadata for the wrong package: expected distribution for sniffio, got distribution for anyio
"
);

Ok(())
}
Loading