Refactor environment validity check into separate function#13025
Merged
Conversation
zanieb
force-pushed
the
zb/project-env-valid
branch
from
225d4c4 to
89cc869
Compare
Now, we can use early returns!
zanieb
force-pushed
the
zb/project-env-valid
branch
from
89cc869 to
1de7a6c
Compare
zanieb
added a commit
that referenced
this pull request
Apr 25, 2025
When working on #13025 I noticed this message was lacking versions, which seems frustrating if you're debugging things. I refactored the general `matches_interpreter` utilities that were added in #12884 into a more purpose-fit function that returns an `Option` with the versions if there's a mismatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, we can use early returns! Pulled out of #7934, where we're adding more logic here.