Consistent sorting in PythonInstallationKey by adjusting variant position#12934
Closed
j178 wants to merge 1 commit intoastral-sh:mainfrom
Closed
Consistent sorting in PythonInstallationKey by adjusting variant position#12934j178 wants to merge 1 commit intoastral-sh:mainfrom
j178 wants to merge 1 commit intoastral-sh:mainfrom
Conversation
j178
force-pushed
the
list-order
branch
3 times, most recently
from
2dc25c0 to
1482194
Compare
…tion This PR shifts the variant to sit right after the version in PythonInstallationKey. For a key like `cpython-3.13.3+freethreaded-windows-x86_64-none`, the variant is essentially part of the version. This change helps make the sorting in the uv python list more logical and consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR shifts the variant to sit right after the version in
PythonInstallationKey. For a key likecpython-3.13.3+freethreaded-windows-x86_64-none, the variant is essentially part of the version. This change helps make the sorting in theuv python listmore logical and consistent.Depends on #12931