Skip to content

feat: Error on dependency object specifier #12811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gankra merged 4 commits into from
Apr 10, 2025
Merged

feat: Error on dependency object specifier #12811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f9ee352
feat: Error on dependency object specifier
kiran-4444 Apr 10, 2025
a7de994
tests: Update snapsnots
kiran-4444 Apr 10, 2025
8876e68
feat: Better error message
kiran-4444 Apr 10, 2025
0e19ef7
tests: Update snapshots
kiran-4444 Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions crates/uv-workspace/src/dependency_groups.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use std::collections::BTreeMap;
use std::str::FromStr;

use thiserror::Error;
use tracing::warn;
use tracing::error;

use uv_normalize::{GroupName, DEV_DEPENDENCIES};
use uv_pep508::Pep508Error;
Expand Down Expand Up @@ -74,9 +74,10 @@ impl FlatDependencyGroups {
.extend(resolved.get(include_group).into_iter().flatten().cloned());
}
DependencyGroupSpecifier::Object(map) => {
warn!(
"Ignoring Dependency Object Specifier referenced by `{name}`: {map:?}"
);
return Err(DependencyGroupError::DependencyObjectSpecifierNotSupported(
name.clone(),
map.clone(),
));
}
}
}
Expand Down Expand Up @@ -154,6 +155,8 @@ pub enum DependencyGroupError {
DevGroupInclude(GroupName),
#[error("Detected a cycle in `dependency-groups`: {0}")]
DependencyGroupCycle(Cycle),
#[error("Group `{0}` contains an unknown dependency object specifier: {1:?}")]
DependencyObjectSpecifierNotSupported(GroupName, BTreeMap<String, String>),
}

impl DependencyGroupError {
Expand Down
11 changes: 6 additions & 5 deletions crates/uv/tests/it/lock.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20832,14 +20832,15 @@ fn lock_group_invalid_entry_table() -> Result<()> {
"#,
)?;

uv_snapshot!(context.filters(), context.lock(), @r###"
success: true
exit_code: 0
uv_snapshot!(context.filters(), context.lock(), @r#"
success: false
exit_code: 1
----- stdout -----

----- stderr -----
Resolved 2 packages in [TIME]
"###);
× Failed to build `project @ file://[TEMP_DIR]/`
╰─▶ Group `foo` contains an unknown dependency object specifier: {"bar": "unknown"}
"#);

Ok(())
}
Expand Down
Loading