docs: Remove note about musl binary distributions#12323
Closed
Wingysam wants to merge 3 commits intoastral-sh:mainfrom
Closed
docs: Remove note about musl binary distributions#12323Wingysam wants to merge 3 commits intoastral-sh:mainfrom
Wingysam wants to merge 3 commits intoastral-sh:mainfrom
Conversation
zanieb
approved these changes
Mar 19, 2025
Member
zanieb
left a comment
zanieb
left a comment
There was a problem hiding this comment.
Thank you! Should we amend this to note that this is the case for aarch64 images instead of deleting it?
Member
|
ha, I see you asked this — I'd be more comfortable mentioning aarch64 / arm64 until we ship support there. |
Author
|
I've restored the note but clarified that it only applies to ARM now. |
Member
|
I thought this had merged, I think now @charliermarsh did this in #12825 — sorry about that. Let me know if anything is missing still. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Now that uv installs Python in musl-based environments (#12121), the docs no longer need to call out that it cannot do this.
Test Plan
Docs-only change.
Question
Should this documentation still call out that it can't install Python on arm systems?