Skip to content

Allow selection of debug build interpreters #11520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zanieb merged 1 commit into from
Sep 12, 2025
Merged

Allow selection of debug build interpreters #11520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions crates/uv-python/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,6 @@ fn process_json(data: &serde_json::Value) -> serde_json::Value {

if let Some(obj) = data.as_object() {
for (key, value) in obj {
if let Some(variant) = value.get("variant") {
// Exclude debug variants for now, we don't support them
if variant == "debug" {
continue;
}
}

Comment on lines -9 to -15
Copy link
Copy Markdown
Contributor

@geofft geofft Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much does this increase the uv file size?

Copy link
Copy Markdown
Contributor

@geofft geofft Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently at most 0.1 MB, seems fine!

Copy link
Copy Markdown
Member Author

@zanieb zanieb Sep 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to measure with release builds, probably a significant amount.

Copy link
Copy Markdown
Member Author

@zanieb zanieb Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks!

out_data.insert(key.clone(), value.clone());
}
}
Expand Down
Loading
Loading