Skip to content

demonstrate current behaviour of corners on current main#11258

Closed
Gankra wants to merge 2 commits intomainfrom
gankra/test-corners
Closed

demonstrate current behaviour of corners on current main#11258
Gankra wants to merge 2 commits intomainfrom
gankra/test-corners

Conversation

@Gankra
Copy link
Contributor

@Gankra Gankra commented Feb 5, 2025

This is the same test commit in #11224 but with an extra commit added where i regen them on main to show how they differ.

You can see that they largely error in the same places except:

  • my PR turns some panics into proper errors
  • my PR newly forbids --all-groups --only-dev while on main it's nonsensically kinda --only-all-groups but just because it's not handled properly and different APIs give different answers
  • my PR newly interprets --all-groups --no-default-groups as --all-groups, while on main it's nonsensically being interpretted as --no-default-groups.
  • they both agree --dev --only-dev saturates to --only-dev (the snapshot churns because of the previous difference, the net result is the same)

@Gankra Gankra added the internal A refactor or improvement that is not user-facing label Feb 5, 2025
@Gankra Gankra closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal A refactor or improvement that is not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant