Skip to content

docs: suggest copy linking for GitLab integration guide #11067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zanieb merged 3 commits into from
Jan 29, 2025
+3 −4
Merged

docs: suggest copy linking for GitLab integration guide #11067

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b916a32
docs: suggest copy linking for GitLab integration guide
fgreinacher Jan 29, 2025
263d1e7
docs: add comment about copy link mode
fgreinacher Jan 29, 2025
27e3489
Update docs/guides/integration/gitlab.md
zanieb Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions docs/guides/integration/gitlab.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,11 @@ variables:
UV_VERSION: 0.5
PYTHON_VERSION: 3.12
BASE_LAYER: bookworm-slim

stages:
- analysis
Comment on lines -20 to -21
Copy link
Copy Markdown
Contributor Author

@fgreinacher fgreinacher Jan 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the stage configuration because it is not needed for this example.

Copy link
Copy Markdown
Member

@zanieb zanieb Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment above this suggesting why it's used?

Copy link
Copy Markdown
Member

@zanieb zanieb Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Above UV_LINK_MODE)

Copy link
Copy Markdown
Contributor Author

@fgreinacher fgreinacher Jan 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done in 263d1e7.

# GitLab CI creates a separate mountpoint for the build directory,
# so we need to copy instead of using hard links.
UV_LINK_MODE: copy

uv:
stage: analysis
image: ghcr.io/astral-sh/uv:$UV_VERSION-python$PYTHON_VERSION-$BASE_LAYER
script:
# your `uv` commands
Expand Down