Conversation
zanieb
commented
Jan 23, 2025
| @@ -240,17 +240,11 @@ impl TestContext { | |||
| #[must_use] | |||
Member
Author
There was a problem hiding this comment.
This is extra clean-up, I could split into a separate change but it's not particularly important.
zanieb
commented
Jan 23, 2025
crates/uv/tests/it/python_install.rs
Outdated
Comment on lines
+183
to
+203
| // We should ignore the broken executable and download a version still | ||
| uv_snapshot!(context.filters(), context.run() | ||
| .env_remove("VIRTUAL_ENV") | ||
| // In tests, we ignore `PATH` during Python discovery so we need to add the context `bin` | ||
| .env("UV_TEST_PYTHON_PATH", context.bin_dir.as_os_str()) | ||
| .arg("-p").arg("3.11") | ||
| .arg("python").arg("-c").arg("import sys; print(sys.version_info[:2])"), @r###" | ||
| success: false | ||
| exit_code: 2 | ||
| ----- stdout ----- | ||
|
|
||
| ----- stderr ----- | ||
| error: Failed to inspect Python interpreter from search path at `/Users/zb/.local/share/uv/tests/[TMP]/python3` | ||
| Caused by: Querying Python at `/Users/zb/.local/share/uv/tests/[TMP]/python3` failed with exit status exit status: 1 | ||
|
|
||
| [stderr] | ||
| error: intentionally broken python executable | ||
| "###); | ||
| } |
zanieb
force-pushed
the
zb/install-auto-test
branch
from
3766382 to
c32e611
Compare
zanieb
added a commit
that referenced
this pull request
Jan 23, 2025
First of all, I want to test automatic managed installs (see #10913) and need to set that up. Second of all, some tests were _implicitly_ downloading interpreters instead of using the one from their context — which is unexpected and naughty and very slow.
zanieb
force-pushed
the
zb/install-auto-test
branch
from
c32e611 to
38616de
Compare
zanieb
force-pushed
the
zb/install-auto-test
branch
2 times, most recently
from
ef20f9d to
e7d5324
Compare
zanieb
force-pushed
the
zb/install-auto-test
branch
from
e7d5324 to
e9043f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverage for #10908 (and more)