Skip to content

Add Windows aarch64 to the release binaries #10885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zanieb merged 1 commit into from
Jan 24, 2025
+3 −0
Merged

Add Windows aarch64 to the release binaries #10885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build-binaries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,8 @@ jobs:
arch: x64
- target: i686-pc-windows-msvc
arch: x86
- target: aarch64-pc-windows-msvc
arch: x64 # not relevant here
Copy link
Copy Markdown
Member

@charliermarsh charliermarsh Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait why not?

Copy link
Copy Markdown
Member Author

@zanieb zanieb Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's only used to install Python, I think?

Copy link
Copy Markdown
Member Author

@zanieb zanieb Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

      - uses: actions/setup-python@v5
        with:
          python-version: ${{ env.PYTHON_VERSION }}
          architecture: ${{ matrix.platform.arch }}

Copy link
Copy Markdown
Member

@charliermarsh charliermarsh Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why don't we need the ARM Python? Haha

Copy link
Copy Markdown
Member Author

@zanieb zanieb Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So... from what I can see we use Python to

  • Transform the README (just needs to match the runner)
  • Install the wheel (which we skip for aarch64)

In brief, you can run x86 Python on the x86-64 machine but you can't run the ARM64 Python. It'd just crash?

Copy link
Copy Markdown
Member Author

@zanieb zanieb Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sneakily.. further down..

      - name: "Test wheel"
        if: ${{ !startsWith(matrix.platform.target, 'aarch64') }}
        shell: bash

Copy link
Copy Markdown
Member

@charliermarsh charliermarsh Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok. So it just needs to match the runner.

steps:
- uses: actions/checkout@v4
with:
Expand Down
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,7 @@ unix-archive = ".tar.gz"
# Target platforms to build apps for (Rust target-triple syntax)
targets = [
"aarch64-apple-darwin",
"aarch64-pc-windows-msvc",
Copy link
Copy Markdown
Contributor

@Gankra Gankra Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...right yeah this shouldn't need a cargo-dist init...

Copy link
Copy Markdown
Member Author

@zanieb zanieb Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did run generate or something

"aarch64-unknown-linux-gnu",
"aarch64-unknown-linux-musl",
"arm-unknown-linux-musleabihf",
Expand Down