Remove the FullCommit variant from GitReference
#10803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
the
internal
charliermarsh
force-pushed
the
charlie/ref
branch
from
aaaa031 to
bdbdd5e
Compare
charliermarsh
force-pushed
the
charlie/ref
branch
from
bdbdd5e to
d86bb5d
Compare
charliermarsh
force-pushed
the
charlie/full-commit
branch
from
167810b to
5f0098b
Compare
charliermarsh
force-pushed
the
charlie/ref
branch
from
d86bb5d to
0647465
Compare
charliermarsh
changed the title
GitOid directly on GitReferenceFullCommit variant from GitReference
konstin
approved these changes
Jan 21, 2025
charliermarsh
force-pushed
the
charlie/full-commit
branch
from
5f0098b to
33ead39
Compare
charliermarsh
force-pushed
the
charlie/ref
branch
from
b1a07e7 to
7d128cb
Compare
charliermarsh
force-pushed
the
charlie/full-commit
branch
from
33ead39 to
b02ad07
Compare
charliermarsh
force-pushed
the
charlie/ref
branch
from
7d128cb to
40e6880
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It's not quite correct for this to be on
GitReference. It's not a variant that can be created by users, or by us.