Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only remove [tool.uv.sources] during uv remove when no longer relevant #8361

Closed
zanieb opened this issue Oct 19, 2024 · 0 comments · Fixed by #8366
Closed

Only remove [tool.uv.sources] during uv remove when no longer relevant #8361

zanieb opened this issue Oct 19, 2024 · 0 comments · Fixed by #8366
Labels
bug Something isn't working help wanted Contribution especially encouraged

Comments

@zanieb
Copy link
Member

zanieb commented Oct 19, 2024

e.g., as demonstrated by #8360 we remove the sources entry on the first uv remove call even though the dependency is still required in the optional-dependencies and dev-dependency sections.
@zanieb zanieb added bug Something isn't working help wanted Contribution especially encouraged labels Oct 19, 2024
@j178 j178 mentioned this issue Oct 19, 2024
Merged
@zanieb zanieb closed this as completed in e980c1b Oct 19, 2024
MtkN1 pushed a commit to MtkN1/uv that referenced this issue Oct 21, 2024
@j178 @MtkN1
Only remove a source from [tool.uv.sources] if it is no long being …
69feb6d 
…referenced (astral-sh#8366)

## Summary

Resolves astral-sh#8361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Contribution especially encouraged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only remove a source from [tool.uv.sources] if it is no long being referenced j178/uv
1 participant
@zanieb