Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If resolution fails after uv add, should we remove the dependency? #5622

Closed
charliermarsh opened this issue Jul 30, 2024 · 3 comments · Fixed by #5664
Closed

If resolution fails after uv add, should we remove the dependency? #5622

charliermarsh opened this issue Jul 30, 2024 · 3 comments · Fixed by #5664
Assignees
@charliermarsh
Labels
bug Something isn't working preview Experimental behavior

Comments

@charliermarsh
Copy link
Member

It's confusing because running uv add again with a different dependency will continue to fail.
@ibraheemdev
Copy link
Member

I think we should. If uv add fails the pyproject.toml should not be updated.

@charliermarsh charliermarsh added bug Something isn't working preview Experimental behavior labels Jul 30, 2024
@charliermarsh
Copy link
Member Author

I tend to agree.

@charliermarsh charliermarsh self-assigned this Jul 31, 2024
@charliermarsh
Copy link
Member Author

I will try to do this tomorrow.

@charliermarsh charliermarsh mentioned this issue Jul 31, 2024
Merged
charliermarsh added a commit that referenced this issue Jul 31, 2024
@charliermarsh
Avoid persisting uv add calls that result in resolver errors (#5664)
4b8a127 
## Summary

Closes #5622.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
bug Something isn't working preview Experimental behavior
Projects
No open projects
uv: release-ready
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid persisting uv add calls that result in resolver errors astral-sh/uv
2 participants
@charliermarsh @ibraheemdev