Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should uv init write an empty dev-dependencies section? #5340

Closed
zanieb opened this issue Jul 23, 2024 · 4 comments
Closed

Should uv init write an empty dev-dependencies section? #5340

zanieb opened this issue Jul 23, 2024 · 4 comments
Labels
cli Related to the command line interface good first issue Good for newcomers preview Experimental behavior

Comments

@zanieb
Copy link
Member

zanieb commented Jul 23, 2024

It seems noisy, the user can add this with uv add --dev foo?

❯ uv init
warning: `uv init` is experimental and may change without warning
Initialized project example

❯ cat pyproject.toml
[project]
name = "example"
version = "0.1.0"
description = "Add your description here"
readme = "README.md"
dependencies = []

[tool.uv]
dev-dependencies = []
@zanieb zanieb added cli Related to the command line interface preview Experimental behavior labels Jul 23, 2024
@charliermarsh
Copy link
Member

I'm fine either way.

@zanieb
Copy link
Member Author

zanieb commented Jul 23, 2024

It seems weird to write a non-standard entry by default if it's empty. I'd prefer to omit it.

@zanieb zanieb added the good first issue Good for newcomers label Jul 23, 2024
@manzt manzt mentioned this issue Jul 24, 2024
Merged
zanieb pushed a commit that referenced this issue Jul 24, 2024
@manzt
Omit empty uv.tool.dev-dependencies on uv init (#5406)
d642705 
<!--
Thank you for contributing to uv! To help us out with reviewing, please
consider the following:

- Does this pull request include a summary of the change? (See below.)
- Does this pull request include a descriptive title?
- Does this pull request include references to any relevant issues?
-->

## Summary

Implements #5340

## Test Plan

<!-- How was it tested? -->
@trag1c
Copy link

trag1c commented Jul 24, 2024

Looks like the PR didn't get picked up by GitHub's thingy, this should probably be closed 😄

@charliermarsh
Copy link
Member

Good call, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli Related to the command line interface good first issue Good for newcomers preview Experimental behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@charliermarsh @zanieb @trag1c