Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uv add allows git-specific flags when irrelevant #5335

Closed
zanieb opened this issue Jul 23, 2024 · 0 comments · Fixed by #5377
Closed

uv add allows git-specific flags when irrelevant #5335

zanieb opened this issue Jul 23, 2024 · 0 comments · Fixed by #5377
Assignees
@charliermarsh
Labels
bug Something isn't working preview Experimental behavior

Comments

@zanieb
Copy link
Member

zanieb commented Jul 23, 2024 •
edited
Loading

e.g.

❯ uv add \
    "https://files.pythonhosted.org/packages/5c/2d/3da5bdf4408b8b2800061c339f240c1802f2e82d55e50bd39c5a881f47f0/httpx-0.27.0.tar.gz" \
    --rev 0.2.0

should at least warn and probably error, but does not. The rev is not written to the pyproject.toml.
@zanieb zanieb added bug Something isn't working preview Experimental behavior labels Jul 23, 2024
@charliermarsh charliermarsh self-assigned this Jul 23, 2024
@charliermarsh charliermarsh mentioned this issue Jul 23, 2024
Merged
charliermarsh added a commit that referenced this issue Jul 23, 2024
@charliermarsh
Reject Git CLI arguments with non-Git sources (#5377)
76566b0 
## Summary

Closes #5335.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
bug Something isn't working preview Experimental behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reject Git CLI arguments with non-Git sources astral-sh/uv
2 participants
@charliermarsh @zanieb