Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --no-pager option to uv help #4941

Closed
zanieb opened this issue Jul 9, 2024 · 3 comments · Fixed by #5007
Closed

Add --no-pager option to uv help #4941

zanieb opened this issue Jul 9, 2024 · 3 comments · Fixed by #5007
Labels
cli Related to the command line interface good first issue Good for newcomers

Comments

@zanieb
Copy link
Member

zanieb commented Jul 9, 2024

To avoid paging if that's your deal.
@zanieb zanieb added good first issue Good for newcomers cli Related to the command line interface labels Jul 9, 2024
@MadGanGithub
Copy link

Hey @zanieb
I would like to work on this issue
Can you assign me?

@silvanocerza
Copy link
Contributor

I'm confused by this issue, uv help doesn't seem to page its output. I actually couldn't find any other command that uses a pager by default. 🤔

Could it be that I have some local config that messes things up?

@silvanocerza
Copy link
Contributor

Nevermind, disregard my previous comment. I'm dumb and should search better. 🤦‍♀️

I also tested using an outdated version of uv instead of main.

@silvanocerza silvanocerza mentioned this issue Jul 12, 2024
Merged
zanieb pushed a commit that referenced this issue Jul 12, 2024
@silvanocerza
Add --no-pager option in help command (#5007)
2ccb7ed 
## Summary

Fixes #4941.

This PR adds a `--no-pager` option in `help` command to explicitly
disable the pager.

I noted that the template used for the text printed when calling `help`
with no argument or option doesn't show any option. It made sense before
this PR since `help` didn't have any available option. Though I'm unsure
if it makes sense to update the template as it would make it extremely
verbose as all the global options would be shown too.

I leave the decision to you.

## Test Plan

I ran `cargo run -- help` to verify `--isolated` was visible and it.
I ran clippy with `cargo clippy --workspace --all-targets --all-features
--locked -- -D warnings` as CI does.

I also ran tests locally with:
```
cargo nextest run \
            --features python-patch \
            --workspace \
            --status-level skip --failure-output immediate-final --no-fail-fast -j 12 --final-status-level slow
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli Related to the command line interface good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add --no-pager option in help command silvanocerza/uv
3 participants
@zanieb @silvanocerza @MadGanGithub