Stop workspace discovery for git and other cache entries at cache entry root #3936
Comments
|
What are Cargo's rules here? |
konstin
added a commit
that referenced
this issue
Oct 29, 2024
When resolving workspace dependencies from a workspace that's in git, we need to convert these transitive dependencies to git dependencies. This fixes a bug where we would treat them as path dependencies inside the checkout directory, leading either to clashes (between a local path and another direct git dependency) or invalid lockfiles (referencing the checkout dir). Fixes #8087 Fixes #4920 Fixes #3936 since we needed that information anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, workspace discovery walks from the project
pyproject.tomlto the file system root to find a workspace pyproject.toml. For cache entries such as git checkout and temporary directories, we should only walk up to the cache entry boundary; we don't want to consider anypyproject.tomlfiles the user may have above the cache root.The text was updated successfully, but these errors were encountered: