Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: When using uv pip compile or uv pip install --dry-run warn and display yank message on selecting a yanked package #3703

Closed
notatallshaw-gts opened this issue May 21, 2024 · 2 comments
Labels
error messages Messaging when something goes wrong

Comments

@notatallshaw-gts
Copy link

uv does not seem to display the the yank message when a yanked package is selected:

$ python -V
Python 3.10.4
$ pip -V
pip 24.0 from ...
$ uv -V
uv 0.1.45

$ pip install --dry-run python-daemon==2.3.1
Collecting python-daemon==2.3.1
  Using cached python_daemon-2.3.1-py2.py3-none-any.whl.metadata (1.7 kB)
Collecting docutils (from python-daemon==2.3.1)
  Using cached docutils-0.21.2-py3-none-any.whl.metadata (2.8 kB)
Collecting lockfile>=0.10 (from python-daemon==2.3.1)
  Using cached lockfile-0.12.2-py2.py3-none-any.whl.metadata (2.4 kB)
Requirement already satisfied: setuptools in /home/STRIKETECH/dshaw/miniforge3/envs/uv_recon/lib/python3.10/site-packages (from python-daemon==2.3.1) (69.5.1)
WARNING: The candidate selected for download or install is a yanked version: 'python-daemon' candidate (version 2.3.1 at https://files.pythonhosted.org/packages/aa/b0/bc79d8ff019c2583d839e0143b1f91eafd4cfe92f86fb9d378a515dfb612/python_daemon-2.3.1-py2.py3-none-any.whl (from https://pypi.org/simple/python-daemon/))
Reason for being yanked: Incorrectly declares Python 2 support
Using cached python_daemon-2.3.1-py2.py3-none-any.whl (34 kB)
Using cached lockfile-0.12.2-py2.py3-none-any.whl (13 kB)
Using cached docutils-0.21.2-py3-none-any.whl (587 kB)
Would install docutils-0.21.2 lockfile-0.12.2 python-daemon-2.3.1

$ uv pip install --dry-run python-daemon==2.3.1
Resolved 4 packages in 3ms
Would download 3 packages
Would install 3 packages
 + docutils==0.21.2
 + lockfile==0.12.2
 + python-daemon==2.3.1
@notatallshaw-gts notatallshaw-gts changed the title Warn and display yank message on selecting a yanked package Feature request: Warn and display yank message on selecting a yanked package May 21, 2024
@notatallshaw-gts notatallshaw-gts changed the title Feature request: Warn and display yank message on selecting a yanked package Feature request: When using pip compile or pip install --dry-run warn and display yank message on selecting a yanked package May 21, 2024
@notatallshaw-gts notatallshaw-gts changed the title Feature request: When using pip compile or pip install --dry-run warn and display yank message on selecting a yanked package Feature request: When using uv pip compile or uv pip install --dry-run warn and display yank message on selecting a yanked package May 21, 2024
@notatallshaw-gts
Copy link
Author

notatallshaw-gts commented May 21, 2024

uv does display when doing regular install:

uv pip install  python-daemon==2.3.1
Resolved 4 packages in 3ms
Downloaded 3 packages in 486ms
Installed 3 packages in 7ms
 + docutils==0.21.2
 + lockfile==0.12.2
 + python-daemon==2.3.1
warning: python-daemon==2.3.1 is yanked (reason: "Incorrectly declares Python 2 support").

But if the yanked version is being pinned in a constraint or requirement file it may be too late, or not noticed, for it to be displayed at install time, instead of requirement build time.

@charliermarsh
Copy link
Member

It would be useful to enumerate the specific cases in which we're not showing this but should (e.g., --dry-run).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error messages Messaging when something goes wrong
Projects
None yet
Development

No branches or pull requests

2 participants